Re: A bug in ftrace - dynamic fops

2016-08-11 Thread Miroslav Benes
On Thu, 11 Aug 2016, Steven Rostedt wrote: > On Thu, 11 Aug 2016 16:08:58 +0200 (CEST) > Miroslav Benes wrote: > > > /* > > * Dynamic ops may be freed, we must make sure that all > > * callers are done before leaving this function. > > * The same goes for freei

Re: A bug in ftrace - dynamic fops

2016-08-11 Thread Steven Rostedt
On Thu, 11 Aug 2016 16:08:58 +0200 (CEST) Miroslav Benes wrote: > /* > * Dynamic ops may be freed, we must make sure that all > * callers are done before leaving this function. > * The same goes for freeing the per_cpu data of the per_cpu > * ops. >

Re: A bug in ftrace - dynamic fops

2016-08-11 Thread Miroslav Benes
On Thu, 11 Aug 2016, Steven Rostedt wrote: > On Thu, 11 Aug 2016 10:46:53 +0200 (CEST) > Miroslav Benes wrote: > > > On Tue, 9 Aug 2016, Steven Rostedt wrote: > > > > > On Tue, 9 Aug 2016 10:16:00 +0200 (CEST) > > > Miroslav Benes wrote: > > > > > > > > > > I agree it is kind of shooting o

Re: A bug in ftrace - dynamic fops

2016-08-11 Thread Steven Rostedt
On Thu, 11 Aug 2016 10:46:53 +0200 (CEST) Miroslav Benes wrote: > On Tue, 9 Aug 2016, Steven Rostedt wrote: > > > On Tue, 9 Aug 2016 10:16:00 +0200 (CEST) > > Miroslav Benes wrote: > > > > > > > I agree it is kind of shooting oneself in the foot bug, because explicit > > > call to a sleepi

Re: A bug in ftrace - dynamic fops

2016-08-11 Thread Miroslav Benes
On Tue, 9 Aug 2016, Steven Rostedt wrote: > On Tue, 9 Aug 2016 10:16:00 +0200 (CEST) > Miroslav Benes wrote: > > > > I agree it is kind of shooting oneself in the foot bug, because explicit > > call to a sleeping function may not be the brightest thing to do. However > > I see two (closely re

Re: A bug in ftrace - dynamic fops

2016-08-09 Thread Steven Rostedt
On Tue, 9 Aug 2016 10:16:00 +0200 (CEST) Miroslav Benes wrote: > I agree it is kind of shooting oneself in the foot bug, because explicit > call to a sleeping function may not be the brightest thing to do. However > I see two (closely related) issues with this. > > 1. It is a change in behavi

Re: A bug in ftrace - dynamic fops

2016-08-09 Thread Miroslav Benes
On Mon, 8 Aug 2016, Steven Rostedt wrote: > On Mon, 8 Aug 2016 10:57:45 +0200 (CEST) > Miroslav Benes wrote: > > > Hi Steven, > > > > I am afraid there is a bug in the current mainline's ftrace when dynamic > > fops are involved. > > I'm sorry but I don't see it. > > > > > ftrace_shutdown()

Re: A bug in ftrace - dynamic fops

2016-08-08 Thread Steven Rostedt
On Mon, 8 Aug 2016 10:57:45 +0200 (CEST) Miroslav Benes wrote: > Hi Steven, > > I am afraid there is a bug in the current mainline's ftrace when dynamic > fops are involved. I'm sorry but I don't see it. > > ftrace_shutdown() relies on schedule_on_each_cpu() which should ensure > that no ta