Re: 3.18.1: broken directory with one file too many

2015-01-07 Thread J. Bruce Fields
On Wed, Jan 07, 2015 at 12:25:06AM +, Holger Hoffstätte wrote: > On Sat, 20 Dec 2014 13:02:43 -0500, J. Bruce Fields wrote: > > > On Thu, Dec 18, 2014 at 08:44:37PM +0100, Holger Hoffstätte wrote: > >> On 12/18/14 18:06, J. Bruce Fields wrote: > >> > Whoops, now I see, the server-side trace ha

Re: 3.18.1: broken directory with one file too many

2014-12-20 Thread Holger Hoffstätte
On 12/20/14 19:02, J. Bruce Fields wrote: > Gah. Does this fix it? It does! Well done. :) Reported-by: Holger Hoffstätte Tested-by: Holger Hoffstätte Thanks! Holger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: 3.18.1: broken directory with one file too many

2014-12-20 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 08:44:37PM +0100, Holger Hoffstätte wrote: > On 12/18/14 18:06, J. Bruce Fields wrote: > > Whoops, now I see, the server-side trace has the same problem, I > > just overlooked it the first time. > > Excellent, so we know it's the server's fault. Really would have been odd t

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread Holger Hoffstätte
On 12/18/14 18:06, J. Bruce Fields wrote: > Whoops, now I see, the server-side trace has the same problem, I > just overlooked it the first time. Excellent, so we know it's the server's fault. Really would have been odd to not have it in the server trace. >> ..in order to rule out a mistake on m

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 10:19:14AM -0500, J. Bruce Fields wrote: > On Thu, Dec 18, 2014 at 09:58:06AM -0500, Benjamin Coddington wrote: > > Frame 36 of nfs-client.pcap has this interesting string: > > > > 0ff0 00 01 3b f6 fb b6 26 16 8f 7c 00 00 00 41 62 74 ..;...&..|...Abt > > 1000 72 66 73 2

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 05:42:36PM +0100, Holger Hoffstätte wrote: > On 12/18/14 17:32, J. Bruce Fields wrote: > > So this is two separate tests, both failed, the only difference is that > > the tcpdump was run on the client in one case and the server in the > > other? > > Exactly: client first, t

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread Holger Hoffstätte
On 12/18/14 17:32, J. Bruce Fields wrote: > So this is two separate tests, both failed, the only difference is that > the tcpdump was run on the client in one case and the server in the > other? Exactly: client first, then I realized you'd want to look at the server-side too. That being said.. >

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 03:42:53PM +, Holger Hoffstätte wrote: > On Thu, 18 Dec 2014 10:19:14 -0500, J. Bruce Fields wrote: > > > On Thu, Dec 18, 2014 at 09:58:06AM -0500, Benjamin Coddington wrote: > >> Frame 36 of nfs-client.pcap has this interesting string: > >> > >> 0ff0 00 01 3b f6 fb b

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 03:35:45PM +, Holger Hoffstätte wrote: > On Thu, 18 Dec 2014 09:48:56 -0500, J. Bruce Fields wrote: > > > On a quick skim, the server's READDIR responses look correct. The entry > > btrfs-20141216-fix-a-warning-of-qgroup-account-on-shared-extents.patch > > is returned

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 09:58:06AM -0500, Benjamin Coddington wrote: > Frame 36 of nfs-client.pcap has this interesting string: > > 0ff0 00 01 3b f6 fb b6 26 16 8f 7c 00 00 00 41 62 74 ..;...&..|...Abt > 1000 72 66 73 2d 32 30 00 00 00 00 00 00 00 00 30 36 rfs-2006 > 1010 2d 66 69 7

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread Benjamin Coddington
Frame 36 of nfs-client.pcap has this interesting string: 0ff0 00 01 3b f6 fb b6 26 16 8f 7c 00 00 00 41 62 74 ..;...&..|...Abt 1000 72 66 73 2d 32 30 00 00 00 00 00 00 00 00 30 36 rfs-2006 1010 2d 66 69 78 2d 64 65 61 64 6c 6f 63 6b 2d 77 68 -fix-deadlock-wh 1020 65 6e 2d 6d 6f 7

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread J. Bruce Fields
On Thu, Dec 18, 2014 at 01:22:40PM +0100, Holger Hoffstätte wrote: > On 12/17/14 22:22, J. Bruce Fields wrote: > > On Tue, Dec 16, 2014 at 10:19:18PM +, Holger Hoffstätte wrote: > >> (..oddly broken directory over NFS..) > > That doesn't sound familiar. A network trace showing the READDIR woul

Re: 3.18.1: broken directory with one file too many

2014-12-18 Thread Holger Hoffstätte
On 12/17/14 22:22, J. Bruce Fields wrote: > On Tue, Dec 16, 2014 at 10:19:18PM +, Holger Hoffstätte wrote: >> (..oddly broken directory over NFS..) > That doesn't sound familiar. A network trace showing the READDIR would > be really useful. Since this is so reproducible, I think that should b

Re: 3.18.1: broken directory with one file too many

2014-12-17 Thread J. Bruce Fields
On Tue, Dec 16, 2014 at 10:19:18PM +, Holger Hoffstätte wrote: > g > (please CC: for followups) > > I just spent two hours trying to untangle a *weird* bug that I have not > seen before. It might be new to 3.18.x but I don't know for sure. > Apologies in advance for the long prelude but I figu