Re: 2.6.20-rc6-mm1

2007-01-30 Thread Anton Altaparmakov
Hi Andrew, Looks good for NTFS thanks! The only thing is that I think we already have a variable "unsigned long flags" in the function ntfs_end_buffer_async_read() so that could be used instead of redefining it more locally in the if statements. Could you send the patch to Linus? Feel free t

Re: 2.6.20-rc6-mm1

2007-01-30 Thread Pierre Ossman
Andrew Morton wrote: > > A quick scan indicates that the following files might be buggy in this > regard: > > drivers/mmc/wbsd.c > drivers/mmc/sdhci.c This are probably even buggier than so. They really should be using page_address(), it seems that kmap_atomic() gives the same result when not us

Re: 2.6.20-rc6-mm1

2007-01-30 Thread Jiri Slaby
Andrew Morton napsal(a): On Mon, 29 Jan 2007 23:27:27 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: On Sun, 28 Jan 2007 11:25:42 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: Andrew Morton napsal(a): Temporarily at http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ I'm still seeing thi

Re: 2.6.20-rc6-mm1

2007-01-30 Thread Andrew Morton
On Mon, 29 Jan 2007 23:27:27 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 28 Jan 2007 11:25:42 +0100 > Jiri Slaby <[EMAIL PROTECTED]> wrote: > > > Andrew Morton napsal(a): > > > Temporarily at > > > > > > http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ > > > > I'm still seeing thi

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Andrew Morton
On Sun, 28 Jan 2007 11:25:42 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > Andrew Morton napsal(a): > > Temporarily at > > > > http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ > > I'm still seeing this during bootup: > BUG: at /home/l/latest/xxx/arch/i386/mm/highmem.c:52 kmap_atomic() > []

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Martin Bligh
Andrew Morton wrote: On Tue, 30 Jan 2007 08:12:31 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: On Sun, Jan 28, 2007 at 03:01:33PM -0800, Andrew Morton wrote: On Sun, 28 Jan 2007 08:56:08 -0800 "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: - It seems that people have been busy creatin

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Andrew Morton
On Tue, 30 Jan 2007 08:12:31 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > On Sun, Jan 28, 2007 at 03:01:33PM -0800, Andrew Morton wrote: > > On Sun, 28 Jan 2007 08:56:08 -0800 > > "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > > > > > - It seems that people have been busy creating th

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Suparna Bhattacharya
On Sun, Jan 28, 2007 at 03:01:33PM -0800, Andrew Morton wrote: > On Sun, 28 Jan 2007 08:56:08 -0800 > "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > > > - It seems that people have been busy creating the need for this. I had > > > to > > > apply over sixty patches to this tree to fix post-2.

Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

2007-01-29 Thread Andrew Morton
On Mon, 29 Jan 2007 03:51:54 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > I think the easy and correct fix for this situation is defining > > CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if > > IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to > > require arch_setup_

Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

2007-01-29 Thread Andi Kleen
> I think the easy and correct fix for this situation is defining > CONFIG_ARCH_HAS_SETUP_ADDITIONAL_PAGES on x86_64 only if > IA32_EMULATION is defined. (Because x86_64 proper doesn't seem to > require arch_setup_additional_pages() only IA32 emulation requires > it.) > > The patch below should fi

Re: 2.6.20-rc6-mm1

2007-01-29 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > Actually, maybe I was confusing this with the fixes Ingo had for > local_bh_disable vs. preemption in the -rt tree. Ingo, do you have > preemptible RCU support in your -rt tree and if so did you have to fix > the networking stack to behave correctly w

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
On Sun, Jan 28, 2007 at 10:43:12PM -0800, Andrew Morton wrote: > > > IIRC Ingo had made fixes for the networking stack in his rt tree since > > the networking code assumes in lots of places that rcu_read_lock > > disables preemption. > > oh. We'd better find those fixes then. I wonder what other

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Mon, 29 Jan 2007 16:29:29 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Jan 29, 2007 at 04:17:44PM +1100, Herbert Xu wrote: > > Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > > > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in > > > preemptible [0001] code: y

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
On Mon, Jan 29, 2007 at 04:17:44PM +1100, Herbert Xu wrote: > Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in > > preemptible [0001] code: yum-updatesd/2846 > > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x36

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in preemptible > [0001] code: yum-updatesd/2846 > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x363/0x47f > [nf_conntrack] > Jan 28 22:58:29 euridica kernel: [] show_

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Sun, 28 Jan 2007 15:23:43 -0800 "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Sun, 28 Jan 2007 08:56:08 -0800 > > "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > > >>> - It seems that people have been busy creating the need for this. I had > >>> to > >>> apply

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Martin J. Bligh
Andrew Morton wrote: On Sun, 28 Jan 2007 08:56:08 -0800 "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: - It seems that people have been busy creating the need for this. I had to apply over sixty patches to this tree to fix post-2.6.20-rc4-mm1 compilation errors. And a number of patches were

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Sun, 28 Jan 2007 23:31:00 +0100 Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in preemptible > [0001] code: yum-updatesd/2846 > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x363/0x47f > [nf_conntrack] I'll plu

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Sun, 28 Jan 2007 08:56:08 -0800 "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > - It seems that people have been busy creating the need for this. I had to > > apply over sixty patches to this tree to fix post-2.6.20-rc4-mm1 > > compilation > > errors. And a number of patches were droppe

Re: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

2007-01-28 Thread Parag Warudkar
On 1/28/07, Parag Warudkar <[EMAIL PROTECTED]> wrote: >CONFIG_BINFMT_ELF=y ># CONFIG_BINFMT_MISC is not set ># CONFIG_IA32_EMULATION is not set Hm Ok. That's explainable. You don't have CONFIG_IA32_EMULATION set and arch_setup_additional pages is only defined/exported in syscall32.c which won't

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Michal Piotrowski
Andrew Morton napisaƂ(a): > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ > > will appear one day at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc6/2.6.20-rc6-mm1/ > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_i

Re: 2.6.20-rc6-mm1 (build)

2007-01-28 Thread Randy Dunlap
On Sat, 27 Jan 2007 23:49:28 -0800 Andrew Morton wrote: > > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ > > will appear one day at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc6/2.6.20-rc6-mm1/ allyesconfig on x86_64 does no

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Martin J. Bligh
- It seems that people have been busy creating the need for this. I had to apply over sixty patches to this tree to fix post-2.6.20-rc4-mm1 compilation errors. And a number of patches were dropped due to no-compile or to runtime errors. Heaven knows how many runtime bugs were added. Wha

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Martin J. Bligh
- It seems that people have been busy creating the need for this. I had to apply over sixty patches to this tree to fix post-2.6.20-rc4-mm1 compilation errors. And a number of patches were dropped due to no-compile or to runtime errors. Heaven knows how many runtime bugs were added. Bui

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Martin J. Bligh
- It seems that people have been busy creating the need for this. I had to apply over sixty patches to this tree to fix post-2.6.20-rc4-mm1 compilation errors. And a number of patches were dropped due to no-compile or to runtime errors. Heaven knows how many runtime bugs were added. d

RE: 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages

2007-01-28 Thread Parag Warudkar
CONFIG_BINFMT_ELF=y # CONFIG_BINFMT_MISC is not set # CONFIG_IA32_EMULATION is not set Hm Ok. That's explainable. You don't have CONFIG_IA32_EMULATION set and arch_setup_additional pages is only defined/exported in syscall32.c which won't be built in your case. (It should go away if you set CONF