> We always used to byte-swap just a few fields in the descriptor, to
> optimise access to those. We never bothered to put them back when we
> passed them up to userspace via usbdevfs -- we gave a structure which
> was mostly LE but had precisely four fields byteswapped to host-endian.
> The upstr
On Fri, Jan 21, 2005 at 08:12:16AM +, David Woodhouse wrote:
> On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote:
> > Well, we should be byteswapping all of the fields that need to be
> > swapped, right? I'm guessing that userspace is expecting the fields
> > to be in cpu endian, correct?
>
>
On Thu, 2005-01-20 at 23:58 -0800, Greg KH wrote:
> Well, we should be byteswapping all of the fields that need to be
> swapped, right? I'm guessing that userspace is expecting the fields
> to be in cpu endian, correct?
Userspace varies in that. Nobody expects _all_ the fields to be swapped;
the
On Fri, Jan 21, 2005 at 07:49:08AM +, David Woodhouse wrote:
> On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote:
> > Doh, sorry for missing this one. I've applied your patch to my trees,
> > and will show up in the next -mm release.
>
> Actually I think John's problem was that the usb core co
On Thu, 2005-01-20 at 16:08 -0800, Greg KH wrote:
> Doh, sorry for missing this one. I've applied your patch to my trees,
> and will show up in the next -mm release.
Actually I think John's problem was that the usb core code has now
_stopped_ doing this byteswapping, and he has a lsusb which is h
On Thu, Jan 20, 2005 at 08:40:07AM +, David Woodhouse wrote:
> On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote:
> > New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the
> > PowerMac.
>
> Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB,
> idVendor, idProduct
> Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB,
> idVendor, idProduct, and bcdDevice fields in the device descriptor. It
> should probably swap them back before copying it up to userspace.
Yes, it happens with 2.6.11-rc1 on my PowerPC, but not with 2.6.10 (or
before), or on m
On Wed, 2005-01-19 at 15:39 -0800, John Mock wrote:
> New to 2.6.11-rc1 is that 'lsusb' exhibits 'endian' problems on the
> PowerMac.
Is that really new to 2.6.11-rc1? The kernel byte-swaps the bcdUSB,
idVendor, idProduct, and bcdDevice fields in the device descriptor. It
should probably swap them
8 matches
Mail list logo
