Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-15 Thread Nathan Lynch
On Tue, Feb 15, 2005 at 08:29:33AM -0700, Zwane Mwaikambo wrote: > On Mon, 14 Feb 2005, Nathan Lynch wrote: > > > It looks as if we need to explicitly bind worker threads to a newly > > onlined cpu. This gets rid of the smp_processor_id warnings from > > cache_reap. Adding a little more instrume

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-15 Thread Zwane Mwaikambo
On Mon, 14 Feb 2005, Nathan Lynch wrote: > It looks as if we need to explicitly bind worker threads to a newly > onlined cpu. This gets rid of the smp_processor_id warnings from > cache_reap. Adding a little more instrumentation to the debug > smp_processor_id showed that new worker threads were

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-14 Thread Ingo Molnar
* Nathan Lynch <[EMAIL PROTECTED]> wrote: > Works ok here. > > It looks as if we need to explicitly bind worker threads to a newly > onlined cpu. This gets rid of the smp_processor_id warnings from > cache_reap. Adding a little more instrumentation to the debug > smp_processor_id showed that n

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-14 Thread Nathan Lynch
On Sat, Feb 12, 2005 at 11:59:04AM -0700, Zwane Mwaikambo wrote: > How about; > > Index: linux-2.6.11-rc3-mm2/kernel/softirq.c > === > RCS file: /home/cvsroot/linux-2.6.11-rc3-mm2/kernel/softirq.c,v > retrieving revision 1.1.1.1 > dif

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-12 Thread Zwane Mwaikambo
On Fri, 11 Feb 2005, Nathan Lynch wrote: > With 2.6.11-rc3-bk7 on ppc64 I am seeing lots of smp_processor_id > warnings whenever I hotplug cpus: > > # echo 0 > /sys/devices/system/cpu/cpu1/online > cpu 1 (hwid 1) Ready to die... > BUG: using smp_processor_id() in preemptible [0001] code: > k

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-11 Thread Nathan Lynch
On Sat, Feb 12, 2005 at 12:56:54AM +0100, Matthias-Christian Ott wrote: > Nathan Lynch wrote: > > >With 2.6.11-rc3-bk7 on ppc64 I am seeing lots of smp_processor_id > >warnings whenever I hotplug cpus: ... > > Use get_cpu() (It disables preemption) or __smp_processor_id () (on a smp). It's not ne

Re: 2.6-bk: cpu hotplug + preempt = smp_processor_id warnings galore

2005-02-11 Thread Matthias-Christian Ott
Nathan Lynch wrote: Hi- With 2.6.11-rc3-bk7 on ppc64 I am seeing lots of smp_processor_id warnings whenever I hotplug cpus: # echo 0 > /sys/devices/system/cpu/cpu1/online cpu 1 (hwid 1) Ready to die... BUG: using smp_processor_id() in preemptible [0001] code: ksoftirqd/1/5 caller is .ksoftirqd