Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Linus Walleij
On Mon, Dec 7, 2020 at 2:25 PM Jerome Brunet wrote: > [Me] > > So maybe the problem is that you need to go back and think about > > updating the DT bindings for this thing to include interrupt-controller > > as well? > > We do > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/t

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Jerome Brunet
On Mon 07 Dec 2020 at 13:34, Linus Walleij wrote: > On Mon, Dec 7, 2020 at 12:07 PM Jerome Brunet wrote: >> On Mon 07 Dec 2020 at 11:18, Andy Shevchenko >> wrote: >> > On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: >> >> On Fri 04 Dec 2020 at 10:13, Linus Walleij >> >> wrote: >> > >>

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Linus Walleij
On Mon, Dec 7, 2020 at 12:07 PM Jerome Brunet wrote: > On Mon 07 Dec 2020 at 11:18, Andy Shevchenko > wrote: > > On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: > >> On Fri 04 Dec 2020 at 10:13, Linus Walleij > >> wrote: > > > >> This HW only has 8 irqs that can each be mapped to a pin. N

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Jerome Brunet
On Mon 07 Dec 2020 at 11:18, Andy Shevchenko wrote: > On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: >> On Fri 04 Dec 2020 at 10:13, Linus Walleij wrote: > >> This HW only has 8 irqs that can each be mapped to a pin. No direct >> translation can be made, we have to allocate an irq to mon

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Andy Shevchenko
On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: > On Fri 04 Dec 2020 at 10:13, Linus Walleij wrote: > This HW only has 8 irqs that can each be mapped to a pin. No direct > translation can be made, we have to allocate an irq to monitor the line. > So when gpio_to_irq() was called, we had to d

Re: 0001-add-amlogic-gpio-to-irq

2020-12-04 Thread Jerome Brunet
On Fri 04 Dec 2020 at 10:13, Linus Walleij wrote: > Hi Lisheng, > > this patch got a bit mangled but I get where you're going. > > I think Meson needs to be augmented to use hierarchical gpiolib irqchip > because this seems to be what the system is doing. > > So start with drivers/pinctrl/meson

Re: 0001-add-amlogic-gpio-to-irq

2020-12-04 Thread Linus Walleij
Hi Lisheng, this patch got a bit mangled but I get where you're going. I think Meson needs to be augmented to use hierarchical gpiolib irqchip because this seems to be what the system is doing. So start with drivers/pinctrl/meson/Kconfig and add: select GPIOLIB_IRQCHIP select IRQ_DOMAIN_HIEARAR