Re: ... and more...

2006-12-07 Thread David Howells
Al Viro <[EMAIL PROTECTED]> wrote: > diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c This could be done differently. m41t00_set() is only called on that global variable, so why pass its address in as an argument? The old code is also wrong: m41t00_set() was being passed a p

Re: ... and more...

2006-12-06 Thread Al Viro
On Wed, Dec 06, 2006 at 07:46:41PM +, Al Viro wrote: Gah... Harmless but stupid: leftover netdev_priv(dev); diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c index 2dd0a34..420377c 100644 --- a/drivers/i2c/chips/m41t00.c +++ b/drivers/i2c/chips/m41t00.c @@ -215,8 +215,15 @