Re: ->poll() instances shouldn't be indefinitely blocking

2015-11-29 Thread Al Viro
On Fri, Nov 27, 2015 at 09:49:11AM -0800, Linus Torvalds wrote: > Al, what do you think? The whole "generic code should be robust wrt > drivers making silly mistakes" just sounds like a good idea. Finding > these things through code inspection is all well and good, but having > a nice warning repo

Re: ->poll() instances shouldn't be indefinitely blocking

2015-11-27 Thread Linus Torvalds
On Fri, Nov 27, 2015 at 7:18 AM, Mauro Carvalho Chehab wrote: > Al Viro escreveu: > >> Take a look at this: >> static unsigned int gsc_m2m_poll(struct file *file, >> struct poll_table_struct *wait) >> { >> struct gsc_ctx *ctx = fh_to_ctx(file->priva

Re: ->poll() instances shouldn't be indefinitely blocking

2015-11-27 Thread Mauro Carvalho Chehab
Em Fri, 27 Nov 2015 05:00:26 + Al Viro escreveu: > Take a look at this: > static unsigned int gsc_m2m_poll(struct file *file, > struct poll_table_struct *wait) > { > struct gsc_ctx *ctx = fh_to_ctx(file->private_data); > struct gsc_dev *