Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-09-13 Thread Atish Patra
On Fri, 2019-09-13 at 13:47 -0700, Palmer Dabbelt wrote: > On Mon, 09 Sep 2019 23:00:10 PDT (-0700), Christoph Hellwig wrote: > > On Fri, Sep 06, 2019 at 11:27:57PM +, Atish Patra wrote: > > > > Agreed. May be something like this ? > > > > > > > > Let's say f/d is enabled in kernel but cpu doe

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-09-13 Thread Palmer Dabbelt
On Mon, 09 Sep 2019 23:00:10 PDT (-0700), Christoph Hellwig wrote: On Fri, Sep 06, 2019 at 11:27:57PM +, Atish Patra wrote: > Agreed. May be something like this ? > > Let's say f/d is enabled in kernel but cpu doesn't support it. > "unsupported isa" will only appear if there are any unsuppor

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-09-09 Thread h...@infradead.org
On Fri, Sep 06, 2019 at 11:27:57PM +, Atish Patra wrote: > > Agreed. May be something like this ? > > > > Let's say f/d is enabled in kernel but cpu doesn't support it. > > "unsupported isa" will only appear if there are any unsupported isa. > > > > processor : 3 > > hart: 4

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-09-06 Thread Atish Patra
On Tue, 2019-08-20 at 00:59 -0700, Atish Patra wrote: > On Sun, 2019-08-18 at 11:16 -0700, h...@infradead.org wrote: > > On Fri, Aug 16, 2019 at 07:21:52PM +, Atish Patra wrote: > > > > > + if (isa[0] != '\0') { > > > > > + /* Add remainging isa strings */ > > > > > +

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-08-20 Thread Atish Patra
On Sun, 2019-08-18 at 11:16 -0700, h...@infradead.org wrote: > On Fri, Aug 16, 2019 at 07:21:52PM +, Atish Patra wrote: > > > > + if (isa[0] != '\0') { > > > > + /* Add remainging isa strings */ > > > > + for (e = isa; *e != '\0'; ++e) { > > > > +#if !defined(C

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-08-19 Thread Jacob Lifshay
On 8/7/19, Atish Patra wrote: > } > } > + if (isa[0] != '\0') { > + /* Add remainging isa strings */ That should be spelled "remaining" > + for (e = isa; *e != '\0'; ++e) { > +#if !defined(CONFIG_VIRTUALIZATION) > + if (e[0] !=

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-08-18 Thread h...@infradead.org
On Fri, Aug 16, 2019 at 07:21:52PM +, Atish Patra wrote: > > > + if (isa[0] != '\0') { > > > + /* Add remainging isa strings */ > > > + for (e = isa; *e != '\0'; ++e) { > > > +#if !defined(CONFIG_VIRTUALIZATION) > > > + if (e[0] != 'h') > > > +#endif > > > +

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-08-16 Thread Atish Patra
On Mon, 2019-08-12 at 08:02 -0700, Christoph Hellwig wrote: > > + for (e = mandatory_ext; *e != '\0'; ++e) { > > + if (isa[0] != e[0]) { > > +#if defined(CONFIG_FP) > > + if ((isa[0] == 'f') || (isa[0] == 'd')) > > + continue; > > +#endif > >

Re: [v5 PATCH] RISC-V: Fix unsupported isa string info.

2019-08-12 Thread Christoph Hellwig
> + for (e = mandatory_ext; *e != '\0'; ++e) { > + if (isa[0] != e[0]) { > +#if defined(CONFIG_FP) > + if ((isa[0] == 'f') || (isa[0] == 'd')) > + continue; > +#endif > + unsupported_isa[index] = e[0]; > +