Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-21 Thread Peter De Schrijver
On Thu, Feb 21, 2013 at 01:25:36PM +0100, Peter De Schrijver wrote: > On Fri, Feb 15, 2013 at 05:45:45PM +0100, Stephen Warren wrote: > > ... > > > > I would suggest removing this clock. It's not actually implemented in the > > > CCF > > > and rather useless. If you would gate the CPU clock from

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-21 Thread Peter De Schrijver
On Fri, Feb 15, 2013 at 05:45:45PM +0100, Stephen Warren wrote: ... > > I would suggest removing this clock. It's not actually implemented in the > > CCF > > and rather useless. If you would gate the CPU clock from the CPU by writing > > to > > this register, how would you ungate it? :) Note th

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-15 Thread Stephen Warren
On 02/15/2013 02:24 AM, Peter De Schrijver wrote: > On Thu, Feb 14, 2013 at 09:15:28PM +0100, Stephen Warren wrote: >> On 02/14/2013 11:59 AM, Hiroshi Doyu wrote: >>> To replace magic number in tegra_car: >>> >>> - clocks = <&tegra_car 28>; >>> + clocks = <&tegra_car CLK

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-15 Thread Peter De Schrijver
On Thu, Feb 14, 2013 at 09:15:28PM +0100, Stephen Warren wrote: > On 02/14/2013 11:59 AM, Hiroshi Doyu wrote: > > To replace magic number in tegra_car: > > > > - clocks = <&tegra_car 28>; > > + clocks = <&tegra_car CLK_HOST1X>; > > > diff --git a/arch/arm/boot/dts/tegr

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Stephen Warren
On 02/14/2013 01:34 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 > +0100: > >> Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove >> the list of clocks. > > Not yet removed. I think that this could be done with the patch which > allows kernel s

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Hiroshi Doyu
Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 +0100: > Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove > the list of clocks. Not yet removed. I think that this could be done with the patch which allows kernel source to include DT header files. > BTW, I assume this pat

Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs

2013-02-14 Thread Stephen Warren
On 02/14/2013 11:59 AM, Hiroshi Doyu wrote: > To replace magic number in tegra_car: > > - clocks = <&tegra_car 28>; > + clocks = <&tegra_car CLK_HOST1X>; > diff --git a/arch/arm/boot/dts/tegra20-car.h b/arch/arm/boot/dts/tegra20-car.h Sorry, forgot a couple small comm