Re: [tip:x86/boot] x86/boot: Clean up pointer casting

2016-05-06 Thread Kees Cook
On Fri, May 6, 2016 at 3:10 AM, Ingo Molnar wrote: > > * Borislav Petkov wrote: > >> This can be simplified even further: >> >> --- >> From: Borislav Petkov >> Date: Fri, 6 May 2016 10:43:21 +0200 >> Subject: [PATCH] x86/boot: Simplify pointer casting in >> choose_random_location() >> >> Pass t

Re: [tip:x86/boot] x86/boot: Clean up pointer casting

2016-05-06 Thread Borislav Petkov
On Fri, May 06, 2016 at 12:36:19PM +0200, Ingo Molnar wrote: > > Hm, your patch throws a lot of warnings during allnoconfig builds: > > In file included from arch/x86/boot/compressed/error.c:6:0: > arch/x86/boot/compressed/misc.h: In function ‘choose_random_location’: > arch/x86/boot/compressed/m

Re: [tip:x86/boot] x86/boot: Clean up pointer casting

2016-05-06 Thread Ingo Molnar
Hm, your patch throws a lot of warnings during allnoconfig builds: In file included from arch/x86/boot/compressed/error.c:6:0: arch/x86/boot/compressed/misc.h: In function ‘choose_random_location’: arch/x86/boot/compressed/misc.h:83:9: warning: return makes pointer from integer without a cast [

Re: [tip:x86/boot] x86/boot: Clean up pointer casting

2016-05-06 Thread Ingo Molnar
* Borislav Petkov wrote: > This can be simplified even further: > > --- > From: Borislav Petkov > Date: Fri, 6 May 2016 10:43:21 +0200 > Subject: [PATCH] x86/boot: Simplify pointer casting in > choose_random_location() > > Pass them down as unsigned long directly and get rid of more casting

Re: [tip:x86/boot] x86/boot: Clean up pointer casting

2016-05-06 Thread Borislav Petkov
On Fri, May 06, 2016 at 12:45:41AM -0700, tip-bot for Kees Cook wrote: > Commit-ID: 2bc1cd39fa9f659956b25e500422e700a6cd4ec3 > Gitweb: http://git.kernel.org/tip/2bc1cd39fa9f659956b25e500422e700a6cd4ec3 > Author: Kees Cook > AuthorDate: Thu, 5 May 2016 15:13:46 -0700 > Committer: Ingo Mol