Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-10 Thread Peter Zijlstra
On Mon, Aug 10, 2015 at 02:02:17PM +, Liang, Kan wrote: > > + case 94: /* 14nm Skylake Desktop */ > > + if (idx == PERF_MSR_SMI || idx = PERF_MSR_PPERF) > > Here is a typo. The rest is OK for me. > I did some simple test on HSX. Yep, fixed that already. > Tested-by: Kan Liang

RE: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-10 Thread Liang, Kan
> On Thu, Aug 06, 2015 at 05:59:43PM +0200, Peter Zijlstra wrote: > > On Thu, Aug 06, 2015 at 08:30:08AM -0700, Andy Lutomirski wrote: > > > On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra > wrote: > > > > On Tue, Aug 04, 2015 at 08:39:27PM +, Liang, Kan wrote: > > > > - default: > > >

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-10 Thread Peter Zijlstra
On Mon, Aug 10, 2015 at 01:19:36PM +0200, Jiri Olsa wrote: > On Tue, Aug 04, 2015 at 02:01:20AM -0700, tip-bot for Andy Lutomirski wrote: > > SNIP > > > + /* unsupported modes and filters */ > > + if (event->attr.exclude_user || > > + event->attr.exclude_kernel || > > + event->a

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-10 Thread Jiri Olsa
On Tue, Aug 04, 2015 at 02:01:20AM -0700, tip-bot for Andy Lutomirski wrote: SNIP > + /* unsupported modes and filters */ > + if (event->attr.exclude_user || > + event->attr.exclude_kernel || > + event->attr.exclude_hv || > + event->attr.exclude_idle || > +

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-09 Thread Andy Lutomirski
On Fri, Aug 7, 2015 at 1:34 AM, Peter Zijlstra wrote: > On Thu, Aug 06, 2015 at 05:59:43PM +0200, Peter Zijlstra wrote: >> On Thu, Aug 06, 2015 at 08:30:08AM -0700, Andy Lutomirski wrote: >> > On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra >> > wrote: >> > > On Tue, Aug 04, 2015 at 08:39:27PM +0

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-07 Thread Peter Zijlstra
On Thu, Aug 06, 2015 at 05:59:43PM +0200, Peter Zijlstra wrote: > On Thu, Aug 06, 2015 at 08:30:08AM -0700, Andy Lutomirski wrote: > > On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra wrote: > > > On Tue, Aug 04, 2015 at 08:39:27PM +, Liang, Kan wrote: > > > - default: > > > -

RE: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-06 Thread Liang, Kan
> + /* Probe the MSRs. */ > + for (i = PERF_MSR_TSC + 1; i < PERF_MSR_EVENT_MAX; i++) { > + u64 val; > > - default: > - err = -ENOTSUPP; > + if (!msr[i].test() || rdmsrl_safe(msr[i].msr, &val)) > + msr[i].attr = NULL; > }

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-06 Thread Peter Zijlstra
On Thu, Aug 06, 2015 at 08:30:08AM -0700, Andy Lutomirski wrote: > On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra wrote: > > On Tue, Aug 04, 2015 at 08:39:27PM +, Liang, Kan wrote: > > - default: > > - err = -ENOTSUPP; > > + if (!msr[i].test() || rdmsrl_safe(m

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-06 Thread Andy Lutomirski
On Thu, Aug 6, 2015 at 8:21 AM, Peter Zijlstra wrote: > On Tue, Aug 04, 2015 at 08:39:27PM +, Liang, Kan wrote: > - default: > - err = -ENOTSUPP; > + if (!msr[i].test() || rdmsrl_safe(msr[i].msr, &val)) > + msr[i].attr = NULL; IIRC rdmsr

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-06 Thread Peter Zijlstra
On Tue, Aug 04, 2015 at 08:39:27PM +, Liang, Kan wrote: > Right, it could be a problem. > How about the patch as below? X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Your outlook wrecked it, please use a less broken MUA. Ho

RE: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Liang, Kan
> On Tue, Aug 4, 2015 at 11:11 AM, Liang, Kan wrote: > > > > > >> > >> On Tue, Aug 4, 2015 at 8:03 AM, Liang, Kan > wrote: > >> > > >> >> > + > >> >> > +enum perf_msr_id { > >> >> > + PERF_MSR_TSC= 0, > >> >> > + PERF_MSR_APERF = 1, > >> >> > +

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Andy Lutomirski
On Tue, Aug 4, 2015 at 11:11 AM, Liang, Kan wrote: > > >> >> On Tue, Aug 4, 2015 at 8:03 AM, Liang, Kan wrote: >> > >> >> > + >> >> > +enum perf_msr_id { >> >> > + PERF_MSR_TSC= 0, >> >> > + PERF_MSR_APERF = 1, >> >> > + PERF_MSR_MPERF

RE: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Liang, Kan
> > On Tue, Aug 4, 2015 at 8:03 AM, Liang, Kan wrote: > > > >> > + > >> > +enum perf_msr_id { > >> > + PERF_MSR_TSC= 0, > >> > + PERF_MSR_APERF = 1, > >> > + PERF_MSR_MPERF = 2, > >> > + PERF_MSR_PPERF

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Andy Lutomirski
On Tue, Aug 4, 2015 at 8:03 AM, Liang, Kan wrote: > >> > + >> > +enum perf_msr_id { >> > + PERF_MSR_TSC= 0, >> > + PERF_MSR_APERF = 1, >> > + PERF_MSR_MPERF = 2, >> > + PERF_MSR_PPERF = 3, >> > + P

RE: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Liang, Kan
> > + > > +enum perf_msr_id { > > + PERF_MSR_TSC= 0, > > + PERF_MSR_APERF = 1, > > + PERF_MSR_MPERF = 2, > > + PERF_MSR_PPERF = 3, > > + PERF_MSR_SMI= 4, > > + > > + PERF_

Re: [tip:perf/core] perf/x86: Add an MSR PMU driver

2015-08-04 Thread Andy Lutomirski
On Tue, Aug 4, 2015 at 2:01 AM, tip-bot for Andy Lutomirski wrote: > Commit-ID: b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4 > Gitweb: http://git.kernel.org/tip/b7b7c7821d932ba18ef6c8eafc8536066b4c2ef4 > Author: Andy Lutomirski I think I'm slightly late to the party reviewing what appears t