Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread Michal Hocko
On Tue 25-09-18 15:04:06, Andrew Morton wrote: > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > wrote: > > > > > It is also used in > > > > automated testing to ensure that vmas get disabled for thp > > > > appropriately > > > > and we used "nh" since that is how PR_SET_THP_DISABLE

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread David Rientjes
On Tue, 25 Sep 2018, Andrew Morton wrote: > > > > It is also used in > > > > automated testing to ensure that vmas get disabled for thp > > > > appropriately > > > > and we used "nh" since that is how PR_SET_THP_DISABLE previously > > > > enforced > > > > this, and those tests now break. > >

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread Andrew Morton
On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes wrote: > > > It is also used in > > > automated testing to ensure that vmas get disabled for thp appropriately > > > and we used "nh" since that is how PR_SET_THP_DISABLE previously enforced > > > this, and those tests now break. > > >

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread David Rientjes
On Tue, 25 Sep 2018, Michal Hocko wrote: > > This is used to identify heap mappings that should be able to fault thp > > but do not, and they normally point to a low-on-memory or fragmentation > > issue. After commit 1860033237d4, our users of PR_SET_THP_DISABLE no > > longer show "nh" for the

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread Michal Hocko
On Tue 25-09-18 12:52:09, David Rientjes wrote: > On Mon, 24 Sep 2018, Vlastimil Babka wrote: > > > On 9/24/18 10:02 PM, Michal Hocko wrote: > > > On Mon 24-09-18 21:56:03, Michal Hocko wrote: > > >> On Mon 24-09-18 12:30:07, David Rientjes wrote: > > >>> Commit 1860033237d4 ("mm: make PR_SET_THP_

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread David Rientjes
On Mon, 24 Sep 2018, Vlastimil Babka wrote: > On 9/24/18 10:02 PM, Michal Hocko wrote: > > On Mon 24-09-18 21:56:03, Michal Hocko wrote: > >> On Mon 24-09-18 12:30:07, David Rientjes wrote: > >>> Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") > >>> introduced a regression i

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-24 Thread Michal Hocko
On Mon 24-09-18 22:43:49, Vlastimil Babka wrote: > On 9/24/18 10:02 PM, Michal Hocko wrote: > > On Mon 24-09-18 21:56:03, Michal Hocko wrote: [...] > >> That being said, I do not object to the patch, I am just trying to > >> understand what is the intended usage for the flag that does try to say >

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-24 Thread Vlastimil Babka
On 9/24/18 10:02 PM, Michal Hocko wrote: > On Mon 24-09-18 21:56:03, Michal Hocko wrote: >> On Mon 24-09-18 12:30:07, David Rientjes wrote: >>> Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") >>> introduced a regression in that userspace cannot always determine the set >>> of

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-24 Thread Michal Hocko
On Mon 24-09-18 21:56:03, Michal Hocko wrote: > On Mon 24-09-18 12:30:07, David Rientjes wrote: > > Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") > > introduced a regression in that userspace cannot always determine the set > > of vmas where thp is ineligible. > > > > User

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-24 Thread Michal Hocko
On Mon 24-09-18 12:30:07, David Rientjes wrote: > Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") > introduced a regression in that userspace cannot always determine the set > of vmas where thp is ineligible. > > Userspace relies on the "nh" flag being emitted as part of /pr