Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-26 Thread Minchan Kim
On Thu, Jan 23, 2014 at 02:22:12PM -0500, Johannes Weiner wrote: > On Thu, Jan 23, 2014 at 02:20:14PM +0900, Minchan Kim wrote: > > On Wed, Jan 22, 2014 at 01:42:17PM -0500, Johannes Weiner wrote: > > > On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > > > > On Fri, Jan 10, 2014 at 01:

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-23 Thread Johannes Weiner
On Thu, Jan 23, 2014 at 02:20:14PM +0900, Minchan Kim wrote: > On Wed, Jan 22, 2014 at 01:42:17PM -0500, Johannes Weiner wrote: > > On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > > > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > > > @@ -123,9 +129,39 @@ static

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-22 Thread Minchan Kim
On Mon, Jan 20, 2014 at 06:17:37PM -0500, Johannes Weiner wrote: > On Fri, Jan 17, 2014 at 11:05:17AM +1100, Dave Chinner wrote: > > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > > emptied out their page p

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-22 Thread Minchan Kim
On Wed, Jan 22, 2014 at 01:42:17PM -0500, Johannes Weiner wrote: > On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > > emptied out their page po

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-22 Thread Johannes Weiner
On Wed, Jan 22, 2014 at 01:57:14AM -0500, Johannes Weiner wrote: > Not at this time, I'll try to look into that. For now, I am updating > the patch to revert the shrinker back to DEFAULT_SEEKS and change the > object count to only include objects above a certain threshold, which > assumes a worst-

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-22 Thread Johannes Weiner
On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-21 Thread Johannes Weiner
On Wed, Jan 22, 2014 at 02:06:07PM +1100, Dave Chinner wrote: > On Tue, Jan 21, 2014 at 12:50:17AM -0500, Johannes Weiner wrote: > > On Tue, Jan 21, 2014 at 02:03:58PM +1100, Dave Chinner wrote: > > > On Mon, Jan 20, 2014 at 06:17:37PM -0500, Johannes Weiner wrote: > > > > On Fri, Jan 17, 2014 at 1

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-21 Thread Dave Chinner
On Tue, Jan 21, 2014 at 12:50:17AM -0500, Johannes Weiner wrote: > On Tue, Jan 21, 2014 at 02:03:58PM +1100, Dave Chinner wrote: > > On Mon, Jan 20, 2014 at 06:17:37PM -0500, Johannes Weiner wrote: > > > On Fri, Jan 17, 2014 at 11:05:17AM +1100, Dave Chinner wrote: > > > > On Fri, Jan 10, 2014 at 0

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-20 Thread Johannes Weiner
On Tue, Jan 21, 2014 at 02:03:58PM +1100, Dave Chinner wrote: > On Mon, Jan 20, 2014 at 06:17:37PM -0500, Johannes Weiner wrote: > > On Fri, Jan 17, 2014 at 11:05:17AM +1100, Dave Chinner wrote: > > > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > > > + /* Only shadow en

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-20 Thread Dave Chinner
On Mon, Jan 20, 2014 at 06:17:37PM -0500, Johannes Weiner wrote: > On Fri, Jan 17, 2014 at 11:05:17AM +1100, Dave Chinner wrote: > > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > > + /* Only shadow entries in there, keep track of this node */ > > > + if (!(node->count & RADIX

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-20 Thread Johannes Weiner
On Fri, Jan 17, 2014 at 11:05:17AM +1100, Dave Chinner wrote: > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-16 Thread Dave Chinner
On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-16 Thread Johannes Weiner
On Wed, Jan 15, 2014 at 01:55:01PM +0800, Bob Liu wrote: > Hi Johannes, > > On 01/11/2014 02:10 AM, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which are

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-14 Thread Bob Liu
Hi Johannes, On 01/11/2014 02:10 AM, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This is p

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-13 Thread Minchan Kim
On Mon, Jan 13, 2014 at 04:39:47PM +0900, Minchan Kim wrote: > On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-12 Thread Minchan Kim
On Fri, Jan 10, 2014 at 01:10:43PM -0500, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2014-01-10 Thread Rik van Riel
On 01/10/2014 01:10 PM, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This is problematic for

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-12-02 Thread Johannes Weiner
On Tue, Dec 03, 2013 at 09:10:52AM +1100, Dave Chinner wrote: > On Mon, Dec 02, 2013 at 02:21:48PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-12-02 Thread Dave Chinner
On Mon, Dec 02, 2013 at 02:21:48PM -0500, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-26 Thread Dave Chinner
On Tue, Nov 26, 2013 at 06:00:10PM -0500, Johannes Weiner wrote: > On Wed, Nov 27, 2013 at 09:29:37AM +1100, Dave Chinner wrote: > > On Tue, Nov 26, 2013 at 04:27:25PM -0500, Johannes Weiner wrote: > > > On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote: > > > > On Sun, Nov 24, 2013 at 0

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-26 Thread Johannes Weiner
On Wed, Nov 27, 2013 at 09:29:37AM +1100, Dave Chinner wrote: > On Tue, Nov 26, 2013 at 04:27:25PM -0500, Johannes Weiner wrote: > > On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote: > > > On Sun, Nov 24, 2013 at 06:38:28PM -0500, Johannes Weiner wrote: > > > > Previously, page cache ra

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-26 Thread Dave Chinner
On Tue, Nov 26, 2013 at 04:27:25PM -0500, Johannes Weiner wrote: > On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote: > > On Sun, Nov 24, 2013 at 06:38:28PM -0500, Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > > emptied out their page p

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-26 Thread Johannes Weiner
On Mon, Nov 25, 2013 at 04:13:32PM -0800, Andrew Morton wrote: > On Sun, 24 Nov 2013 18:38:28 -0500 Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which a

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-26 Thread Johannes Weiner
On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote: > On Sun, Nov 24, 2013 at 06:38:28PM -0500, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, which

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-25 Thread Andrew Morton
On Sun, 24 Nov 2013 18:38:28 -0500 Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This is pr

Re: [patch 9/9] mm: keep page cache radix tree nodes in check

2013-11-25 Thread Dave Chinner
On Sun, Nov 24, 2013 at 06:38:28PM -0500, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This