Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2007-01-10 Thread David Brownell
On Thursday 04 January 2007 5:49 am, Nicolas Ferre wrote: > > I face an issue using the hrtimer instead of the old timer framework > (your patch #4/6). It seems that I do not sample at a sufficient rate > using hrtimer : I see squares when drawing circles ;-) Why do you suspect the sample rate

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2007-01-04 Thread Nicolas Ferre
David Brownell a écrit : On Thursday 28 December 2006 10:22 pm, Dmitry Torokhov wrote: I appied all patches except for hwmon as it had some issues with CONFIG_HWMON handling. Could you please take a look at the patch below and tell me if it works for you? Looked OK, except: +#if defined(CONF

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-29 Thread David Brownell
On Thursday 28 December 2006 10:22 pm, Dmitry Torokhov wrote: > > I appied all patches except for hwmon as it had some issues with CONFIG_HWMON > handling. Could you please take a look at the patch below and tell me if it > works for you? Looked OK, except: > +#if defined(CONFIG_HWMON) || (defin

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-28 Thread Dmitry Torokhov
On Thursday 28 December 2006 17:37, David Brownell wrote: > > > > I think these helpers just obfuscate the code, just call > > > > input_report_*() and input_sync() drectly like you used to do. > > > > > > Fair enough, I had a similar thought.  Imre, could you do that update? > > > > Yes, the pat

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-28 Thread David Brownell
> > > I think these helpers just obfuscate the code, just call > > > input_report_*() and input_sync() drectly like you used to do. > > > > Fair enough, I had a similar thought. Imre, could you do that update? > > Yes, the patch is against the OMAP tree. Thanks ... still hoping that the OMAP t

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-27 Thread Imre Deak
On Fri, Dec 22, 2006 at 12:40:20PM -0800, David Brownell wrote: > On Friday 22 December 2006 12:35 pm, Dmitry Torokhov wrote: > > On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: > > > > > > +static void ads7846_report_pen_state(struct ads7846 *ts, int down) > > > +{ > > > + struct inpu

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-22 Thread David Brownell
On Friday 22 December 2006 12:35 pm, Dmitry Torokhov wrote: > On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: > > > > +static void ads7846_report_pen_state(struct ads7846 *ts, int down) > > +{ > > + struct input_dev*input_dev = ts->input; > > + > > + input_report_key(inpu

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-22 Thread Dmitry Torokhov
On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: +static void ads7846_report_pen_state(struct ads7846 *ts, int down) +{ + struct input_dev*input_dev = ts->input; + + input_report_key(input_dev, BTN_TOUCH, down); + if (!down) + input_report_abs(input_