Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 15:13 +0300, Pekka Enberg wrote: > Hi Rusty, > > On 5/9/07, Rusty Russell <[EMAIL PROTECTED]> wrote: > > Hmm, where would the error go? > > Let it propagate: scan_devices -> lguest_bus_init -> do_initcalls. We > probably don't want to panic() if bus_register and devi

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Pekka Enberg
Hi Rusty, On 5/9/07, Rusty Russell <[EMAIL PROTECTED]> wrote: Hmm, where would the error go? Let it propagate: scan_devices -> lguest_bus_init -> do_initcalls. We probably don't want to panic() if bus_register and device_register fail there either. - To unsubscribe from this list: send

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 13:16 +0300, Pekka Enberg wrote: > Hi Rusty, > > On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > +static void add_lguest_device(unsigned int index) > > +{ > > + struct lguest_device *new; > > + > > + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKN

Re: [patch 2/9] lguest: the guest code

2007-05-09 Thread Pekka Enberg
Hi Rusty, On 5/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: +static void add_lguest_device(unsigned int index) +{ + struct lguest_device *new; + + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE; + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL); +