Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-04 Thread David Rientjes
On Sat, 2 Aug 2014, Johannes Weiner wrote: > > I see one concern: that panic_on_oom == 1 will not trigger on pagefault > > when constrained by cpusets. To address that, I'll state that, since > > cpuset-constrained allocations are the allocation context for pagefaults, > > panic_on_oom == 1 sho

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-02 Thread Johannes Weiner
On Fri, Aug 01, 2014 at 02:42:19PM -0700, David Rientjes wrote: > On Fri, 1 Aug 2014, Johannes Weiner wrote: > > > > > out_of_memory() wants the zonelist that was used during allocation, > > > > not just the random first node's zonelist that's simply picked to > > > > serialize page fault OOM kill

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-01 Thread David Rientjes
On Fri, 1 Aug 2014, Johannes Weiner wrote: > > > out_of_memory() wants the zonelist that was used during allocation, > > > not just the random first node's zonelist that's simply picked to > > > serialize page fault OOM kills system-wide. > > > > > > This would even change how panic_on_oom behave

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-01 Thread Johannes Weiner
On Fri, Aug 01, 2014 at 02:10:37AM -0700, David Rientjes wrote: > On Thu, 31 Jul 2014, Johannes Weiner wrote: > > > out_of_memory() wants the zonelist that was used during allocation, > > not just the random first node's zonelist that's simply picked to > > serialize page fault OOM kills system-wi

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-01 Thread David Rientjes
On Thu, 31 Jul 2014, Johannes Weiner wrote: > out_of_memory() wants the zonelist that was used during allocation, > not just the random first node's zonelist that's simply picked to > serialize page fault OOM kills system-wide. > > This would even change how panic_on_oom behaves for page fault OO

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-07-31 Thread Johannes Weiner
On Wed, Jul 23, 2014 at 06:16:32PM -0700, David Rientjes wrote: > If the pagefault handler is modified to pass a non-NULL zonelist then an > unnecessary check for a NULL zonelist in constrained_alloc() can be removed. > > Signed-off-by: David Rientjes > --- > mm/oom_kill.c | 4 +--- > 1 file cha