Re: [patch 1/2] mm: page trylock rename

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 06:43 +0100, Nick Piggin wrote: > Here's a little something to make up for the occasional extra cacheline > write in add_to_page_cache. Saves an atomic operation and 2 memory barriers > for every add_to_page_cache(). > > I suspect lockdepifying the page lock will also barf w

Re: [patch 1/2] mm: page trylock rename

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 06:12 +0100, Nick Piggin wrote: > Hi, > > OK minus the memory barrier changes for now. Can we possibly please > get these into 2.6.24? > > -- > mm: rename page trylock > > Converting page lock to new locking bitops requires a change of page flag > operation naming, so we m

Re: [patch 1/2] mm: page trylock rename

2007-11-09 Thread Nick Piggin
Here's a little something to make up for the occasional extra cacheline write in add_to_page_cache. Saves an atomic operation and 2 memory barriers for every add_to_page_cache(). I suspect lockdepifying the page lock will also barf without this, too... --- Setting and clearing the page locked whe