Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Thomas Gleixner
On Tue, Feb 09 2021 at 10:22, Josh Poimboeuf wrote: > On Tue, Feb 09, 2021 at 04:12:33PM +0100, Thomas Gleixner wrote: >> On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: >> > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: >> >> #ifdef CONFIG_X86_64 >> >> + >> >> +#ifdef CONFI

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Josh Poimboeuf
On Tue, Feb 09, 2021 at 04:12:33PM +0100, Thomas Gleixner wrote: > On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: > > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: > >> #ifdef CONFIG_X86_64 > >> + > >> +#ifdef CONFIG_UNWINDER_FRAME_POINTER > >> +# define IRQSTACK_CALL_CONST

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Thomas Gleixner
On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: >> #ifdef CONFIG_X86_64 >> + >> +#ifdef CONFIG_UNWINDER_FRAME_POINTER >> +# define IRQSTACK_CALL_CONSTRAINT , ASM_CALL_CONSTRAINT >> +#else >> +# define IRQSTACK_CALL_CONSTRAINT

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-08 Thread Josh Poimboeuf
On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: > #ifdef CONFIG_X86_64 > + > +#ifdef CONFIG_UNWINDER_FRAME_POINTER > +# define IRQSTACK_CALL_CONSTRAINT, ASM_CALL_CONSTRAINT > +#else > +# define IRQSTACK_CALL_CONSTRAINT > +#endif Is this really needed? i.e. does ASM_CALL_CONS

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-08 Thread Borislav Petkov
On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: > The effort to make the ASM entry code slim and unified moved the irq stack > switching out of the low level ASM code so that the whole return from > interrupt work and state handling can be done in C and the ASM code just > handles

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-05 Thread Thomas Gleixner
Uros, On Fri, Feb 05 2021 at 12:03, Uros Bizjak wrote: can you please fix your mail client to generate at least the 'In-Reply-to:' header? Lacking that header breaks threading on lore: https://lore.kernel.org/lkml/20210204204903.350275...@linutronix.de/ Your mail is missing there. Ideal

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-05 Thread Uros Bizjak
> The effort to make the ASM entry code slim and unified moved the irq stack > switching out of the low level ASM code so that the whole return from > interrupt work and state handling can be done in C and the ASM code just > handles the low level details of entry and exit. > > This ended up being