Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-19 Thread Minchan Kim
Hi David, On Wed, Apr 19, 2017 at 04:24:48PM -0700, David Rientjes wrote: > On Wed, 19 Apr 2017, Minchan Kim wrote: > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 24efcc20af91..5d2f3fa41e92 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2174,8 +2174,17 @@ static void get_scan_

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-19 Thread David Rientjes
On Wed, 19 Apr 2017, Minchan Kim wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 24efcc20af91..5d2f3fa41e92 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2174,8 +2174,17 @@ static void get_scan_count(struct lruvec *lruvec, > struct mem_cgroup *memcg, > } > >

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-19 Thread Michal Hocko
On Tue 18-04-17 14:32:56, David Rientjes wrote: [...] > If the suggestion is checking > NR_ACTIVE_ANON + NR_INACTIVE_ANON > total_high_wmark pages, it would be a > separate heurstic to address a problem that I'm not having :) My issue is > specifically when NR_ACTIVE_FILE + NR_INACTIVE_FILE < to

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-18 Thread Minchan Kim
Hi David, On Tue, Apr 18, 2017 at 02:32:56PM -0700, David Rientjes wrote: > On Tue, 18 Apr 2017, Minchan Kim wrote: > > > > The purpose of the code that commit 623762517e23 ("revert 'mm: vmscan: do > > > not swap anon pages just because free+file is low'") reintroduces is to > > > prefer swapping

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-18 Thread David Rientjes
On Tue, 18 Apr 2017, Minchan Kim wrote: > > The purpose of the code that commit 623762517e23 ("revert 'mm: vmscan: do > > not swap anon pages just because free+file is low'") reintroduces is to > > prefer swapping anonymous memory rather than trashing the file lru. > > > > If all anonymous memory

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-18 Thread Michal Hocko
On Mon 17-04-17 17:06:20, David Rientjes wrote: > The purpose of the code that commit 623762517e23 ("revert 'mm: vmscan: do > not swap anon pages just because free+file is low'") reintroduces is to > prefer swapping anonymous memory rather than trashing the file lru. > > If all anonymous memory is

Re: [patch] mm, vmscan: avoid thrashing anon lru when free + file is low

2017-04-17 Thread Minchan Kim
Hello David, On Mon, Apr 17, 2017 at 05:06:20PM -0700, David Rientjes wrote: > The purpose of the code that commit 623762517e23 ("revert 'mm: vmscan: do > not swap anon pages just because free+file is low'") reintroduces is to > prefer swapping anonymous memory rather than trashing the file lru. >