Re: [patch] drm/amd: cleanup get_mfd_cell_dev()

2016-02-27 Thread walter harms
Am 27.02.2016 11:40, schrieb Dan Carpenter: > On Sat, Feb 27, 2016 at 10:50:40AM +0100, walter harms wrote: >> >> >> Am 25.02.2016 08:47, schrieb Dan Carpenter: >>> It's simpler to just use snprintf() to print this to one buffer instead >>> of using strcpy() and strcat(). Also using snprintf() i

Re: [patch] drm/amd: cleanup get_mfd_cell_dev()

2016-02-27 Thread Dan Carpenter
On Sat, Feb 27, 2016 at 10:50:40AM +0100, walter harms wrote: > > > Am 25.02.2016 08:47, schrieb Dan Carpenter: > > It's simpler to just use snprintf() to print this to one buffer instead > > of using strcpy() and strcat(). Also using snprintf() is slightly safer > > than using sprintf(). > > >

Re: [patch] drm/amd: cleanup get_mfd_cell_dev()

2016-02-27 Thread walter harms
Am 25.02.2016 08:47, schrieb Dan Carpenter: > It's simpler to just use snprintf() to print this to one buffer instead > of using strcpy() and strcat(). Also using snprintf() is slightly safer > than using sprintf(). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [patch] drm/amd: cleanup get_mfd_cell_dev()

2016-02-26 Thread Alex Deucher
On Thu, Feb 25, 2016 at 2:47 AM, Dan Carpenter wrote: > It's simpler to just use snprintf() to print this to one buffer instead > of using strcpy() and strcat(). Also using snprintf() is slightly safer > than using sprintf(). > > Signed-off-by: Dan Carpenter Applied. Thanks! > > diff --git a/