Re: [patch] drivers: phy: tweaks to phy_create()

2013-11-11 Thread Kishon Vijay Abraham I
Hi Dan, On Wednesday 06 November 2013 01:24 PM, Dan Carpenter wrote: > If this was called with a NULL "dev" then it lead to a NULL dereference > when we called dev_WARN(). I have changed it to WARN_ON() so that we > get a stack dump and can fix the caller. > > If ida_simple_get() failed then the

Re: [patch] drivers: phy: tweaks to phy_create()

2013-11-06 Thread Dan Carpenter
On Wed, Nov 06, 2013 at 01:41:26PM +0530, Kishon Vijay Abraham I wrote: > >The rest of this patch is just cleanup like returning directly instead > >of having do-nothing gotos. Using descriptive labels instead of > > Grouping the err returns in the end looked a bit cleaner to me. It's > just a m

Re: [patch] drivers: phy: tweaks to phy_create()

2013-11-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 01:24 PM, Dan Carpenter wrote: If this was called with a NULL "dev" then it lead to a NULL dereference when we called dev_WARN(). I have changed it to WARN_ON() so that we get a stack dump and can fix the caller. If ida_simple_get() failed then there was a mis