Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-07-23 Thread Dan Carpenter
On Mon, Jun 16, 2014 at 11:27:36AM -0700, Joe Perches wrote: > > > Likely the \\[a-zA-Z] check should include > > > all the tests that the multiple line string exceptions use. > > > > > > (?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$ > > > > That kind of complicate regex hurts my h

Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-06-16 Thread Joe Perches
On Mon, 2014-06-16 at 09:40 +0300, Dan Carpenter wrote: > On Fri, Jun 13, 2014 at 12:52:25PM -0700, Joe Perches wrote: > > On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote: > > > On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote: > > > > > > > > +# check for missing a space in a st

Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-06-15 Thread Dan Carpenter
On Fri, Jun 13, 2014 at 12:52:25PM -0700, Joe Perches wrote: > On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote: > > On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote: > > > > > > +# check for missing a space in a string concatination > > > > +if ($prevrawline =~ /[^\\][a-z

Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-06-13 Thread Joe Perches
On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote: > On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote: > > > > +# check for missing a space in a string concatination > > > +if ($prevrawline =~ /[^\\][a-zA-Z]"$/ && $rawline =~ /^\+[\t > > > ]+"[a-zA-Z]/) { > > > +

Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-06-13 Thread Dan Carpenter
On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote: > > +# check for missing a space in a string concatination > > +if ($prevrawline =~ /[^\\][a-zA-Z]"$/ && $rawline =~ /^\+[\t > > ]+"[a-zA-Z]/) { > > +WARN('MISSING_SPACE', > > + "break quoted strings

Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

2014-06-13 Thread Joe Perches
On Fri, 2014-06-13 at 09:53 +0300, Dan Carpenter wrote: > Checkpatch already complains when people break up quoted strings but > it's still pretty common. One mistake that people often make is they > leave out the space character between the two strings. > > This check adds 453 new warnings. The