Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

2001-01-04 Thread Alan Cox
> udelay(15000); /* delay 15ms */ > > the comment is just extra baggage. No sense touching it generally, but if > you're gonna change it to mdelay.. The comments are 15 (50) implying someone swapped them around for a reason and noted it - To unsubscribe from this list: send the line "unsubscrib

Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

2001-01-04 Thread Oliver Xymoron
On Fri, 5 Jan 2001, Alan Cox wrote: > > Once the comments are unweirded, they become completely superfluous. At > > which point its best not to have them - when someone next comes along and > > changes the delay, it might end up disagreeing with the comment and > > causing confusion. > > Before y

Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

2001-01-04 Thread Alan Cox
> Once the comments are unweirded, they become completely superfluous. At > which point its best not to have them - when someone next comes along and > changes the delay, it might end up disagreeing with the comment and > causing confusion. Before you remove the comments check with the author and

Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

2001-01-04 Thread Oliver Xymoron
On Thu, 4 Jan 2001, Marko Kreen wrote: > On Wed, Jan 03, 2001 at 11:32:52PM +0200, Marko Kreen wrote: > > -udelay(15000); /* delay for 50 (15) ms */ > > +mdelay(15); /* delay for 50 (15) ms */ > > Per Mark Hahn suggestion here is a patch that fixes the weird > comments too. This is cumul

Re: [patch] big udelay's in fb drivers (2.4.0-prerelease)

2001-01-03 Thread Marko Kreen
On Wed, Jan 03, 2001 at 11:32:52PM +0200, Marko Kreen wrote: > -udelay(15000); /* delay for 50 (15) ms */ > +mdelay(15); /* delay for 50 (15) ms */ Per Mark Hahn suggestion here is a patch that fixes the weird comments too. This is cumulative to the previous patch. -- marko --- linu