Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-02-14 Thread Calvin Johnson
On Mon, Feb 08, 2021 at 03:31:11PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > > +int phylink_fwnode_phy_connect(struct phylink *pl, > > + struct fwnode_handle *fwnode, > > + u32 f

Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-02-14 Thread Calvin Johnson

Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-02-08 Thread Russell King - ARM Linux admin
On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. > > Signed-off-by: Calvin Johnson Also, the subject line should be "net: phylink: ..." Consistency is really appreciated. Thanks.

Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-02-08 Thread Russell King - ARM Linux admin
On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > +int phylink_fwnode_phy_connect(struct phylink *pl, > +struct fwnode_handle *fwnode, > +u32 flags) > +{ > + struct fwnode_handle *phy_fwnode; > + struct phy_device *phy_