Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Linus Torvalds
On Tue, Nov 22, 2016 at 2:28 PM, Eric Dumazet wrote: > > This is fixed by : > https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c9b8af1330198ae241cd545e1f040019010d44d9 Thanks guys. This was one of the less esoteric-looking regressions, so I'm happy to hear it's solved.

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 14:04, Linus Torvalds wrote > what's the situation on this issue? The bisection looks a bit odd, > but the commit in question does end up changing the key_control->thoff > value for the failure case, so maybe that in turn ends up screwing up > a later skb_pull. > > I'm not seeing

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 2:04 PM, Linus Torvalds wrote: > David, Eric, > > what's the situation on this issue? The bisection looks a bit odd, > but the commit in question does end up changing the key_control->thoff > value for the failure case, so maybe that in turn ends up screwing up > a later s

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Linus Torvalds
David, Eric, what's the situation on this issue? The bisection looks a bit odd, but the commit in question does end up changing the key_control->thoff value for the failure case, so maybe that in turn ends up screwing up a later skb_pull. I'm not seeing anything that might fix this in the last n

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-15 Thread Ye Xiaolong
On 11/16, Duyck, Alexander H wrote: >On Wed, 2016-11-16 at 05:20 +0800, kernel test robot wrote: >From what I can tell it looks like the size of the frame is 0x160 hex, >or 352.  For whatever reason we are only pulling 8 bytes into the >header which is giving us an skb->len of 352 (0x160), and a sk

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-15 Thread Duyck, Alexander H
On Wed, 2016-11-16 at 05:20 +0800, kernel test robot wrote: > FYI, we noticed the following commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 34fad54c2537f7c99d07375e50cb30aa3c23bd83 ("net: __skb_flow_dissect() > must cap its return value") > > in tes