Re: [git pull] vfs.git pile 2: several fixes to backport

2019-05-07 Thread pr-tracker-bot
The pull request you sent on Tue, 7 May 2019 01:58:42 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git stable-fodder has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/78438ce18f26dbcaa8993bb45d20ffb0cec3bc3e Thank you! -- Deet-doot-dot, I am a bot. h

Re: [git pull] vfs.git pile 2

2016-12-18 Thread Darrick J. Wong
On Sun, Dec 18, 2016 at 04:06:06AM +, Al Viro wrote: > On Sat, Dec 17, 2016 at 07:34:45PM -0800, Linus Torvalds wrote: > > > What else am I missing there? > > > > I absolutely *abhor* this part: > > > > *len = isize - pos_in; > > > > because the whole code then depends on the

Re: [git pull] vfs.git pile 2

2016-12-17 Thread Al Viro
On Sat, Dec 17, 2016 at 07:34:45PM -0800, Linus Torvalds wrote: > > What else am I missing there? > > I absolutely *abhor* this part: > > *len = isize - pos_in; > > because the whole code then depends on the overflow checking a few > lines down, and it's not at all obvious. We ha

Re: [git pull] vfs.git pile 2

2016-12-17 Thread Linus Torvalds
On Sat, Dec 17, 2016 at 7:26 PM, Al Viro wrote: > > One, AFAICS - pointless *len = 0 in case of is_dedupe. Yup. That part made sense in the original code where len and ret were different. Now it just looks like a five-year old has been eating crayons and paste. > What else am I missing there?

Re: [git pull] vfs.git pile 2

2016-12-17 Thread Al Viro
[Darrick Cc'd] On Sat, Dec 17, 2016 at 06:49:55PM -0800, Linus Torvalds wrote: > On Fri, Dec 16, 2016 at 2:12 PM, Al Viro wrote: > > In this pile: > > * autofs-namespace series > > * dedupe stuff > > * more struct path constification > > When looking at the conflict, I loo

Re: [git pull] vfs.git pile 2

2016-12-17 Thread Linus Torvalds
On Fri, Dec 16, 2016 at 2:12 PM, Al Viro wrote: > In this pile: > * autofs-namespace series > * dedupe stuff > * more struct path constification When looking at the conflict, I looked at that part of vfs_clone_file_prep_inodes(), and reacted to the insanity. WTF?

Re: [git pull] vfs.git pile 2

2014-12-16 Thread Al Viro
On Tue, Dec 16, 2014 at 01:33:30PM +, Al Viro wrote: > On Mon, Dec 15, 2014 at 11:51:25PM +, Al Viro wrote: > > Next pile (and there'll be one or two more). The large piece in this one is > > getting rid of /proc/*/ns/* weirdness; among other things, it allows to > > (finally) make nameida

Re: [git pull] vfs.git pile 2

2014-12-16 Thread Al Viro
On Mon, Dec 15, 2014 at 11:51:25PM +, Al Viro wrote: > Next pile (and there'll be one or two more). The large piece in this one is > getting rid of /proc/*/ns/* weirdness; among other things, it allows to > (finally) make nameidata completely opaque outside of fs/namei.c, making for > easier f