Re: [git pull] vfs.git part 3

2017-07-08 Thread Al Viro
On Fri, Jul 07, 2017 at 04:00:02PM +0200, Christoph Hellwig wrote: > On Fri, Jul 07, 2017 at 12:27:49AM +0100, Al Viro wrote: > > On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote: > > > > Which sparse version are you using and what's your .config? > > > > > > sparse is v0.5.0-62-g

Re: [git pull] vfs.git part 3

2017-07-07 Thread Christopher Li
On Fri, Jul 7, 2017 at 8:48 AM, Linus Torvalds wrote: > The releases are done way too seldom to be useful, but that may be > improving. There is one fairly imminent, and it's probably a good idea > to just test the current git tree. Yes guilty of too few releases. We are cutting one release prett

Re: [git pull] vfs.git part 3

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 7:00 AM, Christoph Hellwig wrote: > > So what's the current story on sparse versions to use and releases? The releases are done way too seldom to be useful, but that may be improving. There is one fairly imminent, and it's probably a good idea to just test the current git t

Re: [git pull] vfs.git part 3

2017-07-07 Thread Christoph Hellwig
On Fri, Jul 07, 2017 at 12:27:49AM +0100, Al Viro wrote: > On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote: > > > Which sparse version are you using and what's your .config? > > > > sparse is v0.5.0-62-gce18a90, .config is attached. > > Arrgh... OK, I see what's going on. spar

Re: [git pull] vfs.git part 3

2017-07-06 Thread Al Viro
On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote: > > Which sparse version are you using and what's your .config? > > sparse is v0.5.0-62-gce18a90, .config is attached. Arrgh... OK, I see what's going on. sparse commit affecting that is "Allow casting to a restricted type if !r

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
> Which sparse version are you using and what's your .config? sparse is v0.5.0-62-gce18a90, .config is attached. .config Description: application/config

Re: [git pull] vfs.git part 3

2017-07-06 Thread Al Viro
On Thu, Jul 06, 2017 at 06:58:37PM +0200, Christoph Hellwig wrote: > On Thu, Jul 06, 2017 at 04:51:13PM +0100, Al Viro wrote: > > On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote: > > > > > That - on #work.read_write, as in vfs.git at the moment... > > > > ... and for COMPAT_SYSCALL you ne

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 04:51:13PM +0100, Al Viro wrote: > On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote: > > > That - on #work.read_write, as in vfs.git at the moment... > > ... and for COMPAT_SYSCALL you need > #define __SC_DELOUSE(t,v) ((__force t)(unsigned long)(v)) > in linux/compa

Re: [git pull] vfs.git part 3

2017-07-06 Thread Al Viro
On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote: > That - on #work.read_write, as in vfs.git at the moment... ... and for COMPAT_SYSCALL you need #define __SC_DELOUSE(t,v) ((__force t)(unsigned long)(v)) in linux/compat.h

Re: [git pull] vfs.git part 3

2017-07-06 Thread Al Viro
On Thu, Jul 06, 2017 at 05:10:33PM +0200, Christoph Hellwig wrote: > On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote: > > On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote: > > > > > Just did the whole batch (patch below), but it seems like using a > > > __bitwise type in S

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote: > On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote: > > > Just did the whole batch (patch below), but it seems like using a > > __bitwise type in SYSCALL_DEFINE* will always give warnings like: > > > > fs/read_write.c:1095:

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote: > #define __SC_CAST(t, a) (__force t) a > > in syscalls.h Hmm. > > > index a2d4a8ac94ca..a04adbc70ddf 100644 > > --- a/include/uapi/linux/aio_abi.h > > +++ b/include/uapi/linux/aio_abi.h > > @@ -28,6 +28,7 @@ > > #define __LINUX__AIO_ABI

Re: [git pull] vfs.git part 3

2017-07-06 Thread Al Viro
On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote: > Just did the whole batch (patch below), but it seems like using a > __bitwise type in SYSCALL_DEFINE* will always give warnings like: > > fs/read_write.c:1095:1: warning: cast to restricted __kernel_rwf_t > > which I'm not sure

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 12:29:12AM +0100, Al Viro wrote: > On Thu, Jul 06, 2017 at 12:52:35AM +0200, Christoph Hellwig wrote: > > On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote: > > > Sure, makes sense - especially since it's not too widely spread yet. > > > > Do you want to do that yours

Re: [git pull] vfs.git part 3

2017-07-05 Thread Al Viro
On Thu, Jul 06, 2017 at 12:52:35AM +0200, Christoph Hellwig wrote: > On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote: > > Sure, makes sense - especially since it's not too widely spread yet. > > Do you want to do that yourself, or do you want me to look into it? I'll do it tomorrow, unles

Re: [git pull] vfs.git part 3

2017-07-05 Thread Christoph Hellwig
On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote: > Sure, makes sense - especially since it's not too widely spread yet. Do you want to do that yourself, or do you want me to look into it?

Re: [git pull] vfs.git part 3

2017-07-05 Thread Al Viro
On Wed, Jul 05, 2017 at 02:51:43PM -0700, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 12:14 AM, Al Viro wrote: > > > > Christoph's fs/read_write.c series - consolidation and cleanups. > > Side note - when looking through this, it struck me how confusing that > "int flags" argument was. > > We

Re: [git pull] vfs.git part 3

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 12:14 AM, Al Viro wrote: > > Christoph's fs/read_write.c series - consolidation and cleanups. Side note - when looking through this, it struck me how confusing that "int flags" argument was. We have a ton of "flags" in the filesystem layer, and how all the read/write helpe