Re: [git pull] vfs.git: poll annotations

2018-02-01 Thread Al Viro
On Wed, Jan 31, 2018 at 04:46:20AM +, Al Viro wrote: > On Tue, Jan 30, 2018 at 07:19:19PM -0800, Linus Torvalds wrote: > > On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote: > > > > > > As for the place for mangle/demangle... where would you prefer them? > > > > If we can make gcc generate ok co

Re: [git pull] vfs.git: poll annotations

2018-01-31 Thread Al Viro
On Wed, Jan 31, 2018 at 04:46:20AM +, Al Viro wrote: > MSG and REMOVE are never triggered, so it's all down to {WR{NORM,BAND},RDHUP}. Actually, POLLREMOVE is an amusing story (FSVO amusing): it's a part of UnixWare /dev/poll ABI. It had _not_ lasted in Linux - epoll_ctl() EPOLL_CTL_DEL is us

Re: [git pull] vfs.git: poll annotations

2018-01-30 Thread Al Viro
On Tue, Jan 30, 2018 at 07:19:19PM -0800, Linus Torvalds wrote: > On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote: > > > > As for the place for mangle/demangle... where would you prefer them? > > If we can make gcc generate ok code for the generic case and not need > any arch-specific ones, why no

Re: [git pull] vfs.git: poll annotations

2018-01-30 Thread Linus Torvalds
On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote: > > As for the place for mangle/demangle... where would you prefer them? If we can make gcc generate ok code for the generic case and not need any arch-specific ones, why not just do in ? (And I guess POLLIN/OUT/ERR are standard, so it's only a cou

Re: [git pull] vfs.git: poll annotations

2018-01-30 Thread Al Viro
On Tue, Jan 30, 2018 at 06:21:37PM -0800, Linus Torvalds wrote: > On Tue, Jan 30, 2018 at 10:39 AM, Al Viro wrote: > > Introduces a __bitwise type for POLL... bitmap, propagates > > the annotations through the tree. > > Ok, I'm not entirely happy with this. > > I don't think the mangle/d

Re: [git pull] vfs.git: poll annotations

2018-01-30 Thread Linus Torvalds
On Tue, Jan 30, 2018 at 10:39 AM, Al Viro wrote: > Introduces a __bitwise type for POLL... bitmap, propagates > the annotations through the tree. Ok, I'm not entirely happy with this. I don't think the mangle/demangle_poll() stuff should be in the uapi headers, and it really worries me t