On Sat, Feb 27, 2021 at 08:21:55AM -0800, Linus Torvalds wrote:
> On Fri, Feb 26, 2021 at 10:00 PM Al Viro wrote:
> >
> > Al Viro (3):
> > 9p: fix misuse of sscanf() in v9fs_stat2inode()
>
> Hmm. Technically this changes some of the rules. It used to check that
> i tall fit in 32 bytes. Now
The pull request you sent on Sat, 27 Feb 2021 06:00:29 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.misc
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5ceabb6078b80a8544ba86d6ee523ad755ae6d5e
Thank you!
--
Deet-doot-dot, I am a bot.
http
On Fri, Feb 26, 2021 at 10:00 PM Al Viro wrote:
>
> Al Viro (3):
> 9p: fix misuse of sscanf() in v9fs_stat2inode()
Hmm. Technically this changes some of the rules. It used to check that
i tall fit in 32 bytes. Now there could be arbitrary spaces in there
that pushes it over the limit.
I do
The pull request you sent on Sun, 17 Jan 2021 03:21:15 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a527a2b32d20a2bd8070f49e98cb1a89b0c98bb3
Thank you!
--
Deet-doot-dot, I am a bot.
https://
The pull request you sent on Thu, 24 Dec 2020 23:35:07 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.misc
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7bb5226c8a4bbf26a9ededc90532b0ad539d2017
Thank you!
--
Deet-doot-dot, I am a bot.
http
The pull request you sent on Thu, 22 Oct 2020 07:01:28 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.set_fs
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f56e65dff6ad52395ef45738799b4fb70ff43376
Thank you!
--
Deet-doot-dot, I am a bot.
ht
The pull request you sent on Mon, 12 Oct 2020 04:17:22 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.iov_iter
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/85ed13e78dbedf9433115a62c85429922bc5035c
Thank you!
--
Deet-doot-dot, I am a bot.
The pull request you sent on Mon, 12 Oct 2020 04:19:53 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.quota-compat
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e18afa5bfa4a2f0e07b0864370485df701dacbc1
Thank you!
--
Deet-doot-dot, I am a b
The pull request you sent on Mon, 12 Oct 2020 04:27:48 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git compat.mount
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/22230cd2c55bd27ee2c3a3def97c0d5577a75b82
Thank you!
--
Deet-doot-dot, I am a bot.
h
The pull request you sent on Mon, 12 Oct 2020 04:14:55 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.csum_and_copy
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c90578360c92c71189308ebc71087197080e94c3
Thank you!
--
Deet-doot-dot, I am a
The pull request you sent on Sun, 11 Oct 2020 19:06:09 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5b697f86f9f136d200c9827d6eca0437b7eb96cf
Thank you!
--
Deet-doot-dot, I am a bot.
https://
The pull request you sent on Wed, 3 Jun 2020 20:26:15 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.splice
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ae03c53d005ef8a1e0253ad67b7b62103ea1fae6
Thank you!
--
Deet-doot-dot, I am a bot.
htt
The pull request you sent on Tue, 28 Apr 2020 22:18:55 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/96c9a7802af7d500a582d89a8b864584fe878c1b
Thank you!
--
Deet-doot-dot, I am a bot.
https://
On Mon, Sep 16, 2019 at 6:35 PM Al Viro wrote:
>
> pathwalk-related stuff
That could have done with a few more words of explanation.
I added "Audit-related cleanups, misc simplifications, and easier to
follow nd->root refcounts"
Linus
The pull request you sent on Wed, 31 Jul 2019 19:53:27 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5c6207539aea8b22490f9569db5aa72ddfd0d486
Thank you!
--
Deet-doot-dot, I am a bot.
https://
The pull request you sent on Sat, 20 Jul 2019 04:02:18 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.dcache2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/18253e034d2aeee140f82fc9fe89c4bce5c81799
Thank you!
--
Deet-doot-dot, I am a bot.
h
The pull request you sent on Fri, 19 Jul 2019 04:44:19 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.mount0
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/933a90bf4f3505f8ec83bda21a3c7d70d7c2b426
Thank you!
--
Deet-doot-dot, I am a bot.
ht
The pull request you sent on Fri, 19 Jul 2019 04:45:15 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.adfs
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d2fbf4b6d585e40f2369675148777abce3abd0e7
Thank you!
--
Deet-doot-dot, I am a bot.
http
The pull request you sent on Fri, 19 Jul 2019 04:46:04 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.misc
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4f5ed1318c0108369a76f4a56242fbeea537abe9
Thank you!
--
Deet-doot-dot, I am a bot.
http
The pull request you sent on Fri, 17 May 2019 04:11:26 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/bf8a9a4755737f6630756f0d87bea9b38f0ed369
Thank you!
--
Deet-doot-dot, I am a bot.
https://
The pull request you sent on Fri, 10 May 2019 03:33:33 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13
Thank you!
--
Deet-doot-dot, I am a bot.
https://
The pull request you sent on Tue, 7 May 2019 21:49:21 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.mount-syscalls
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/400913252d09f9cfb8cce33daee43167921fc343
Thank you!
--
Deet-doot-dot, I am a
The pull request you sent on Tue, 7 May 2019 21:53:19 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.misc
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/149e703cb8bfcbdae46140b108bb6f7d2407df8f
Thank you!
--
Deet-doot-dot, I am a bot.
https
The pull request you sent on Tue, 7 May 2019 21:52:09 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.file
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d897166d8598e362a31d79dfd9a1e2eedb9ac85c
Thank you!
--
Deet-doot-dot, I am a bot.
https
The pull request you sent on Tue, 7 May 2019 21:33:55 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.dcache
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d27fb65bc2389621040e5107baedb94b4cccf641
Thank you!
--
Deet-doot-dot, I am a bot.
htt
The pull request you sent on Tue, 7 May 2019 01:50:37 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.icache
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/168e153d5ebbdd6a3fa85db1cc4879ed4b7030e0
Thank you!
--
Deet-doot-dot, I am a bot.
htt
The pull request you sent on Tue, 7 May 2019 01:58:42 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git stable-fodder
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/78438ce18f26dbcaa8993bb45d20ffb0cec3bc3e
Thank you!
--
Deet-doot-dot, I am a bot.
h
The pull request you sent on Sun, 5 May 2019 03:18:46 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/51987affd626b8e4ce9f4c65e1950cb9159f0f58
Thank you!
--
Deet-doot-dot, I am a bot.
https://k
The pull request you sent on Sun, 3 Mar 2019 03:42:53 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4f9020ffde71ddb92bc2f65ce0b00232bc88c590
Thank you!
--
Deet-doot-dot, I am a bot.
https://k
On Sat, Mar 2, 2019 at 7:43 PM Al Viro wrote:
>
> Assorted fixes that sat in -next for a while, all over the
> place.
Is this for the merge window or _very_ late fixes for 5.0?
One of the commits doesn't look appropriate for this (very late) stage
of the rc series: "cgroup: saner refcoun
The pull request you sent on Fri, 4 Jan 2019 19:26:48 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git mount.part1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/505b050fdf42097883b2d37b8e796e1f11dbef50
Thank you!
--
Deet-doot-dot, I am a bot.
htt
On Sat, Jan 05, 2019 at 01:31:21PM -0600, Eric W. Biederman wrote:
> Not having had a chance to review this code I can't really comment on
> the quality of this code. What I do know from a glance is that
> you have not removed FS_BINARY_MOUNTDATA. Which is the root cause
> of some of the crazy s
Al Viro writes:
> mount API prereqs. Mostly that's LSM mount options cleanups.
> One trivial conflict in security/selinux/hooks.c, resolved by taking
> the variant from this branch - the method has been split, leaving
> only the part that used to be conditional upon "it's not an internal
>
The pull request you sent on Fri, 30 Nov 2018 05:15:22 +:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5f1ca5c619c2af5e03114b0276642cdc15d11a94
Thank you!
--
Deet-doot-dot, I am a bot.
https://
On Wed, Jan 31, 2018 at 04:46:20AM +, Al Viro wrote:
> On Tue, Jan 30, 2018 at 07:19:19PM -0800, Linus Torvalds wrote:
> > On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote:
> > >
> > > As for the place for mangle/demangle... where would you prefer them?
> >
> > If we can make gcc generate ok co
On Wed, Jan 31, 2018 at 04:46:20AM +, Al Viro wrote:
> MSG and REMOVE are never triggered, so it's all down to {WR{NORM,BAND},RDHUP}.
Actually, POLLREMOVE is an amusing story (FSVO amusing): it's a part of
UnixWare /dev/poll ABI. It had _not_ lasted in Linux - epoll_ctl()
EPOLL_CTL_DEL is us
On Tue, Jan 30, 2018 at 07:19:19PM -0800, Linus Torvalds wrote:
> On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote:
> >
> > As for the place for mangle/demangle... where would you prefer them?
>
> If we can make gcc generate ok code for the generic case and not need
> any arch-specific ones, why no
On Tue, Jan 30, 2018 at 7:13 PM, Al Viro wrote:
>
> As for the place for mangle/demangle... where would you prefer them?
If we can make gcc generate ok code for the generic case and not need
any arch-specific ones, why not just do in ?
(And I guess POLLIN/OUT/ERR are standard, so it's only a cou
On Tue, Jan 30, 2018 at 06:21:37PM -0800, Linus Torvalds wrote:
> On Tue, Jan 30, 2018 at 10:39 AM, Al Viro wrote:
> > Introduces a __bitwise type for POLL... bitmap, propagates
> > the annotations through the tree.
>
> Ok, I'm not entirely happy with this.
>
> I don't think the mangle/d
On Tue, Jan 30, 2018 at 10:39 AM, Al Viro wrote:
> Introduces a __bitwise type for POLL... bitmap, propagates
> the annotations through the tree.
Ok, I'm not entirely happy with this.
I don't think the mangle/demangle_poll() stuff should be in the uapi
headers, and it really worries me t
On Sat, Nov 18, 2017 at 09:45:31PM +, Al Viro wrote:
> in __get_user_pages_locked(), or am I missing something subtle there? Andrea?
You're not missing anything as far as the logic is concerned.
However see the __always_inline, I added "notify_drop" purely to
optimize away such branch at bui
On Fri, Nov 17, 2017 at 09:32:15PM +, Al Viro wrote:
[snip]
> drivers/infiniband/hw/mthca/mthca_memfree.c:475:ret =
> get_user_pages(uaddr & PAGE_MASK, 1, FOLL_WRITE, pages, NULL);
[snip]
> Itanic
> one is almost certainly buggered - we are not holding ->mmap_sem there.
So's the mth
On Fri, Nov 17, 2017 at 1:32 PM, Al Viro wrote:
> On Fri, Nov 17, 2017 at 12:50:47PM -0800, Linus Torvalds wrote:
>
>> Not because the conversion was wrong, but because the original code is
>> so broken.
>>
>> In particular, that "1" that is unchanged in the arguments is correct
>> in the conversi
On Fri, Nov 17, 2017 at 09:32:15PM +, Al Viro wrote:
> And for get_user_pages() itself it's even more ridiculous - vmalist (the last
> argument) is non-NULL in only one caller. Which uses it only to check if all
> of the VMAs happen to be hugetlb ones, apparently.
>
> FWIW, I wanted to trim
On Fri, Nov 17, 2017 at 12:50:47PM -0800, Linus Torvalds wrote:
> Not because the conversion was wrong, but because the original code is
> so broken.
>
> In particular, that "1" that is unchanged in the arguments is correct
> in the conversion, but it was completely wrong in the original, even
>
On Thu, Nov 16, 2017 at 7:02 PM, Al Viro wrote:
> A bunch of places switched to get_user_pages_fast().
I really would have liked a bit of a commentary.
Looking at the individual patches, I notice this, for example:
- down_read(¤t->mm->mmap_sem);
- page_nr = g
On Sun, Oct 15, 2017 at 2:58 AM, Pavel Machek wrote:
>
> up is quite short and not-specific for global symbol. Rename to mutex_up?
Well, it is quite the traditional name in the OS community and in
Linux it goes back to before the 1.0 release.
We've got about 450 each of the up() and the down() (
On Tue 2017-09-26 02:00:36, Al Viro wrote:
> On Mon, Sep 25, 2017 at 03:18:29PM -0700, Kyle Huey wrote:
> > Beginning with 553f770ef71b, the following program fails when compiled
> > for 32 bit and executed on a 64 bit kernel and succeeds when compiled
> > for and executed on a 64 bit. It continue
On Wed, 11 Oct 2017 00:54:57 -0400,
Al Viro wrote:
>
> Fairly old DIO bug caught by Andreas (3.10+) and several slightly
> younger blk_rq_map_user_iov() bugs, both on map and copy codepaths (Vitaly
> and me).
I ran work.iov_iter changeset through our smoke test few days ago - no apparent
s
On Wed, Oct 11, 2017 at 10:03 AM, Al Viro wrote:
>
> Can I assume your normal S-o-b on that? Just noticed that thing sitting
> in misc queue with mismatched Author: and Signed-off-by:...
Yup, just add my sign-off.
Thanks,
Linus
On Wed, Oct 11, 2017 at 06:03:35PM +0100, Al Viro wrote:
> On Mon, Sep 25, 2017 at 07:02:16PM -0700, Linus Torvalds wrote:
> > On Mon, Sep 25, 2017 at 6:46 PM, Al Viro wrote:
> > >
> > > Which tree do you prefer it to go through? Direct to mainline, or vfs.git
> > > #for-next?
> >
> > for-next,
On Mon, Sep 25, 2017 at 07:02:16PM -0700, Linus Torvalds wrote:
> On Mon, Sep 25, 2017 at 6:46 PM, Al Viro wrote:
> >
> > Which tree do you prefer it to go through? Direct to mainline, or vfs.git
> > #for-next?
>
> for-next, it's not like it's in any way urgent.
Can I assume your normal S-o-b o
Christoph Hellwig writes:
> On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
>> Pulled and pushed out, but I'd like to note that sparse would have
>> caught this. Except we are so far away from being sparse-clean that
>> nobody runs it.
>
> I tend to run sparse over the nvme code b
On Mon, Sep 25, 2017 at 07:07:01PM -0700, Linus Torvalds wrote:
> On Mon, Sep 25, 2017 at 7:03 PM, Linus Torvalds
> wrote:
> >
> > I agree. It might be better to just remove the address space logic,
> > because afaik it never worked for them.
>
> .. and sadly, we should probably disable the locki
On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
> Pulled and pushed out, but I'd like to note that sparse would have
> caught this. Except we are so far away from being sparse-clean that
> nobody runs it.
I tend to run sparse over the nvme code before sending pull request
every tim
On Mon, Sep 25, 2017 at 07:07:01PM -0700, Linus Torvalds wrote:
> On Mon, Sep 25, 2017 at 7:03 PM, Linus Torvalds
> wrote:
> >
> > I agree. It might be better to just remove the address space logic,
> > because afaik it never worked for them.
>
> .. and sadly, we should probably disable the locki
On Mon, Sep 25, 2017 at 7:03 PM, Linus Torvalds
wrote:
>
> I agree. It might be better to just remove the address space logic,
> because afaik it never worked for them.
.. and sadly, we should probably disable the locking ones by default
too, because while they *work*, sparse only handles static
On Mon, Sep 25, 2017 at 7:00 PM, Al Viro wrote:
>
> FWIW, __percpu and __rcu annotations are messy as hell. Never got around
> to sorting down the infrastructure annotations for that bunch, and I'm
> not entirely sure that they (especially __rcu) are a good match for
> __address_space__(()).
I a
On Mon, Sep 25, 2017 at 6:46 PM, Al Viro wrote:
>
> Which tree do you prefer it to go through? Direct to mainline, or vfs.git
> #for-next?
for-next, it's not like it's in any way urgent.
Linus
On Tue, Sep 26, 2017 at 02:46:56AM +0100, Al Viro wrote:
> On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
>
> > And I think your recent compat cleanup work actually made it worse,
> > showing new warnings (including the one that was a real bug)
>
> Actually, they are not new - tr
On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
> And I think your recent compat cleanup work actually made it worse,
> showing new warnings (including the one that was a real bug)
Actually, they are not new - try make C=2 ipc/compat.o on v4.13 and you'll
see their previous locati
On Mon, Sep 25, 2017 at 6:00 PM, Al Viro wrote:
>
> I really wish gcc warned about conversions from pointer to function into
> void *...
Pulled and pushed out, but I'd like to note that sparse would have
caught this. Except we are so far away from being sparse-clean that
nobody runs it.
And I th
On Thu, Sep 21, 2017 at 05:59:57AM -1000, Linus Torvalds wrote:
> On Wed, Sep 20, 2017 at 6:13 PM, Al Viro wrote:
> > A couple of regression fixes, one for this merge window, one for
> > the previous cycle.
>
> That older fix for 4.13 doesn't seem to be marked for stable.
>
> Can you mak
On Wed, Sep 20, 2017 at 6:13 PM, Al Viro wrote:
> A couple of regression fixes, one for this merge window, one for
> the previous cycle.
That older fix for 4.13 doesn't seem to be marked for stable.
Can you make sure it gets to Greg?
Linus
On Fri, Jul 07, 2017 at 04:00:02PM +0200, Christoph Hellwig wrote:
> On Fri, Jul 07, 2017 at 12:27:49AM +0100, Al Viro wrote:
> > On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote:
> > > > Which sparse version are you using and what's your .config?
> > >
> > > sparse is v0.5.0-62-g
On Fri, Jul 07, 2017 at 10:27:38PM -0700, Linus Torvalds wrote:
> On Fri, Jul 7, 2017 at 5:29 PM, Al Viro wrote:
> > There used to be 6 places in the entire tree calling
> > __copy_in_user(),
> > all of them bogus. Four got killed off in work.drm branch, this takes care
> > of
> > the r
On Sat, Jul 8, 2017 at 3:30 AM, Al Viro wrote:
> Assorted normal VFS / filesystems stuff...
>
> [this is not all; there are several branches left, but that's for tomorrow]
>
> The following changes since commit 41f1830f5a7af77cf5c86359aba3cbd706687e52:
>
> Linux 4.12-rc6 (2017-06-19 22:1
On Fri, Jul 7, 2017 at 5:29 PM, Al Viro wrote:
> There used to be 6 places in the entire tree calling __copy_in_user(),
> all of them bogus. Four got killed off in work.drm branch, this takes care of
> the remaining ones and kills the definition of that sucker.
This branch is garbage.
Y
On Fri, Jul 7, 2017 at 5:29 PM, Al Viro wrote:
>
> Trivial conflicts with libnvdimm; this stuff will get some
> followups, but again, that's for another series.
Gaah. Yeah, I guess I could have done the trivial ugly merge that just
took the new copy_from_iter_flushcache() as-is, and didn'
Linus Torvalds writes:
> On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
> wrote:
>>
>>> Patch coming.
>>
>> I'm not seeing a patch, so I did my own. But it's _entirely_ untested.
>> Does the attached fix things for you?
>
> Oh, I see you sent a patch to the list but didn't cc me like in this thr
Linus Torvalds writes:
> On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
> wrote:
>>
>> The copy_flock_fields() macro has the arguments in order ,
>> but all the users seem to do it the other way around.
>
> Looking more at it, I think I'd also like copy_flock_fields() to take
> pointer arguments
On Fri, Jul 7, 2017 at 8:48 AM, Linus Torvalds
wrote:
> The releases are done way too seldom to be useful, but that may be
> improving. There is one fairly imminent, and it's probably a good idea
> to just test the current git tree.
Yes guilty of too few releases. We are cutting one release prett
On Fri, Jul 07, 2017 at 10:35:41AM -0700, Linus Torvalds wrote:
> Comments? Michael, does this work for your case?
Looks sane...
> +++ b/fs/fcntl.c
> @@ -520,50 +520,50 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned
> int, cmd,
>
> #ifdef CONFIG_COMPAT
> /* careful - don't use anywh
On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
wrote:
>
> The copy_flock_fields() macro has the arguments in order ,
> but all the users seem to do it the other way around.
Looking more at it, I think I'd also like copy_flock_fields() to take
pointer arguments, to match all the code around it (bo
On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
wrote:
>
>> Patch coming.
>
> I'm not seeing a patch, so I did my own. But it's _entirely_ untested.
> Does the attached fix things for you?
Oh, I see you sent a patch to the list but didn't cc me like in this thread.
Hmm. Al - I'd like to add the "
On Fri, Jul 7, 2017 at 5:46 AM, Michael Ellerman wrote:
> Al Viro writes:
>
>>
>> Switch flock copyin/copyout primitives to copy_{from,to}_user()
>> (2017-06-26 23:52:44 -0400)
>
> This commit seems to have broken networking on a bunch of my PPC
> machines (64-bit kernel, 32-bit userspace).
B
On Fri, Jul 7, 2017 at 7:00 AM, Christoph Hellwig wrote:
>
> So what's the current story on sparse versions to use and releases?
The releases are done way too seldom to be useful, but that may be
improving. There is one fairly imminent, and it's probably a good idea
to just test the current git t
On Fri, Jul 07, 2017 at 12:27:49AM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote:
> > > Which sparse version are you using and what's your .config?
> >
> > sparse is v0.5.0-62-gce18a90, .config is attached.
>
> Arrgh... OK, I see what's going on. spar
On Thu, Jul 6, 2017 at 2:11 AM, Al Viro wrote:
> uaccess str...() dead code removals.
Side note: you left a couple of references to strlen_user() still in the tree.
None of them *matter* (two comments and one declaration for the
function that no longer exists), but it just strikes me as
On Thu, Jul 6, 2017 at 2:20 PM, Al Viro wrote:
>
> Linus, could you hold that one back until tomorrow? I want to tweak the
> last commit in there a bit, but I want to give it a local beating first...
Ok, dropping this one. All your other branches are merged now.
Linus
On Thu, Jul 6, 2017 at 2:11 AM, Al Viro wrote:
> [6 more piles tonight with several more left for tomorrow]
Tiny side note (since I'm starting to look at this pile soon): it
would be nice if your subject line had the very short "this is what
it's about" thing to it too.
I don't mind the numberin
On Thu, Jul 06, 2017 at 11:44:49PM +0200, Christoph Hellwig wrote:
> > Which sparse version are you using and what's your .config?
>
> sparse is v0.5.0-62-gce18a90, .config is attached.
Arrgh... OK, I see what's going on. sparse commit affecting that
is "Allow casting to a restricted type if !r
> Which sparse version are you using and what's your .config?
sparse is v0.5.0-62-gce18a90, .config is attached.
.config
Description: application/config
On Thu, Jul 06, 2017 at 09:29:27PM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 09:18:26PM +0100, Al Viro wrote:
> > On Thu, Jul 06, 2017 at 12:45:36PM -0700, Kees Cook wrote:
> > >
> > > + if (unlikely(!check_copy_size(addr, bytes, false)))
> > > + return false;
> > > + else
> > > +
On Thu, Jul 06, 2017 at 09:18:26PM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 12:45:36PM -0700, Kees Cook wrote:
> >
> > + if (unlikely(!check_copy_size(addr, bytes, false)))
> > + return false;
> > + else
> > + return _copy_from_iter_full(addr, bytes, i);
> >
> > Can these b
On Thu, Jul 06, 2017 at 12:45:36PM -0700, Kees Cook wrote:
>
> + if (unlikely(!check_copy_size(addr, bytes, false)))
> + return false;
> + else
> + return _copy_from_iter_full(addr, bytes, i);
>
> Can these be rewritten to avoid the double-negative?
Matter of taste - I've no stro
On Thu, Jul 6, 2017 at 2:12 AM, Al Viro wrote:
> iov_iter/uaccess/hardening pile. For one thing, it trims the
> inline part of copy_to_user/copy_from_user to the minimum that *does*
> need to be inlined - object size checks, basically. For another,
> it sanitizes the checks for iov_iter
On Thu, Jul 06, 2017 at 06:58:37PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 06, 2017 at 04:51:13PM +0100, Al Viro wrote:
> > On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote:
> >
> > > That - on #work.read_write, as in vfs.git at the moment...
> >
> > ... and for COMPAT_SYSCALL you ne
On Thu, Jul 06, 2017 at 04:51:13PM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote:
>
> > That - on #work.read_write, as in vfs.git at the moment...
>
> ... and for COMPAT_SYSCALL you need
> #define __SC_DELOUSE(t,v) ((__force t)(unsigned long)(v))
> in linux/compa
On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote:
> That - on #work.read_write, as in vfs.git at the moment...
... and for COMPAT_SYSCALL you need
#define __SC_DELOUSE(t,v) ((__force t)(unsigned long)(v))
in linux/compat.h
On Thu, Jul 06, 2017 at 05:10:33PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote:
> > On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote:
> >
> > > Just did the whole batch (patch below), but it seems like using a
> > > __bitwise type in S
On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote:
>
> > Just did the whole batch (patch below), but it seems like using a
> > __bitwise type in SYSCALL_DEFINE* will always give warnings like:
> >
> > fs/read_write.c:1095:
On Thu, Jul 06, 2017 at 04:03:30PM +0100, Al Viro wrote:
> #define __SC_CAST(t, a) (__force t) a
>
> in syscalls.h
Hmm.
>
> > index a2d4a8ac94ca..a04adbc70ddf 100644
> > --- a/include/uapi/linux/aio_abi.h
> > +++ b/include/uapi/linux/aio_abi.h
> > @@ -28,6 +28,7 @@
> > #define __LINUX__AIO_ABI
On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote:
> Just did the whole batch (patch below), but it seems like using a
> __bitwise type in SYSCALL_DEFINE* will always give warnings like:
>
> fs/read_write.c:1095:1: warning: cast to restricted __kernel_rwf_t
>
> which I'm not sure
On Thu, Jul 06, 2017 at 12:29:12AM +0100, Al Viro wrote:
> On Thu, Jul 06, 2017 at 12:52:35AM +0200, Christoph Hellwig wrote:
> > On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote:
> > > Sure, makes sense - especially since it's not too widely spread yet.
> >
> > Do you want to do that yours
On Thu, Jul 06, 2017 at 12:52:35AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote:
> > Sure, makes sense - especially since it's not too widely spread yet.
>
> Do you want to do that yourself, or do you want me to look into it?
I'll do it tomorrow, unles
On Wed, Jul 05, 2017 at 11:38:21PM +0100, Al Viro wrote:
> Sure, makes sense - especially since it's not too widely spread yet.
Do you want to do that yourself, or do you want me to look into it?
On Wed, Jul 05, 2017 at 02:51:43PM -0700, Linus Torvalds wrote:
> On Wed, Jul 5, 2017 at 12:14 AM, Al Viro wrote:
> >
> > Christoph's fs/read_write.c series - consolidation and cleanups.
>
> Side note - when looking through this, it struck me how confusing that
> "int flags" argument was.
>
> We
On Wed, Jul 5, 2017 at 12:14 AM, Al Viro wrote:
>
> Christoph's fs/read_write.c series - consolidation and cleanups.
Side note - when looking through this, it struck me how confusing that
"int flags" argument was.
We have a ton of "flags" in the filesystem layer, and how all the
read/write helpe
On Wed, Jul 05, 2017 at 01:33:52PM -0700, Linus Torvalds wrote:
> On Wed, Jul 5, 2017 at 12:15 AM, Al Viro wrote:
> >
> > That's probably it for today; again, I apologize for the amount of
> > pull requests, but the tree topologydd is really nasty t
1 - 100 of 182 matches
Mail list logo
