Re: [git pull] gadgetfs fixes

2015-03-16 Thread Alexander Holler
Am 15.03.2015 um 09:31 schrieb Alexander Holler: Am 15.03.2015 um 09:17 schrieb Al Viro: On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote: Umm... If I'm not misparsing what you said, you are talking about the Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung

Re: [git pull] gadgetfs fixes

2015-03-15 Thread Al Viro
On Sun, Mar 15, 2015 at 09:50:01AM +0100, Alexander Holler wrote: > Hmm, a year ago or so I've stumbled over the fact that the owner > might be necessary for correct entries in sysfs (that was mtd). I've > no idea if that's true here too but it might be worse to mention it. There are two mechanis

Re: [git pull] gadgetfs fixes

2015-03-15 Thread Alexander Holler
Am 15.03.2015 um 09:17 schrieb Al Viro: Another question, if you don't mind - does that series (i.e. what's currently in Linus' tree) fix the module refcount issues you'd been seeing? I agree with your analysis of likely cause (->f_op reassignments with different ->owner before and after) and t

Re: [git pull] gadgetfs fixes

2015-03-15 Thread Alexander Holler
Am 15.03.2015 um 09:17 schrieb Al Viro: On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote: Umm... If I'm not misparsing what you said, you are talking about the Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal mit meiner bevorzugten Sprache versuchen. Go

Re: [git pull] gadgetfs fixes

2015-03-15 Thread Al Viro
On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote: > > Umm... If I'm not misparsing what you said, you are talking about the > > Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal > mit meiner bevorzugten Sprache versuchen. Good. I'll probably abstain from try

Re: [git pull] gadgetfs fixes

2015-03-14 Thread Alexander Holler
Am 15.03.2015 um 02:39 schrieb Al Viro: > On Sun, Mar 15, 2015 at 01:39:21AM +0100, Alexander Holler wrote: >> Am 13.03.2015 um 17:42 schrieb Al Viro: >>> Assorted fixes around AIO on gadgetfs: leaks, use-after-free, >>> troubles caused by ->f_op flipping. Please, pull from >>> git://git.kerne

Re: [git pull] gadgetfs fixes

2015-03-14 Thread Al Viro
On Sun, Mar 15, 2015 at 01:39:21AM +0100, Alexander Holler wrote: > Am 13.03.2015 um 17:42 schrieb Al Viro: > > Assorted fixes around AIO on gadgetfs: leaks, use-after-free, > > troubles caused by ->f_op flipping. Please, pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git

Re: [git pull] gadgetfs fixes

2015-03-14 Thread Alexander Holler
Am 13.03.2015 um 17:42 schrieb Al Viro: > Assorted fixes around AIO on gadgetfs: leaks, use-after-free, > troubles caused by ->f_op flipping. Please, pull from > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git gadget > > Shortlog: > Al Viro (8): > new helper: dup_iter() >