Re: [git patches] ocfs2 update

2008-02-07 Thread Joel Becker
On Thu, Feb 07, 2008 at 01:37:15PM -0800, Mark Fasheh wrote: > On Thu, Feb 07, 2008 at 12:47:45PM -0800, Andrew Morton wrote: > > On Thu, 7 Feb 2008 12:09:44 -0800 > > Mark Fasheh <[EMAIL PROTECTED]> wrote: > > > > > +static int dlm_protocol_compare(struct dlm_protocol_version *existing, > > > +

Re: [git patches] ocfs2 update

2008-02-07 Thread Andrew Morton
On Thu, 7 Feb 2008 13:37:15 -0800 Mark Fasheh <[EMAIL PROTECTED]> wrote: > > Please integrate checkpatch into your processes - this one had a few little > > glitches. > > FWIW - I've run all patches through checkpatch.pl since your last review. cool, thanks. > This one went through a couple cyc

Re: [git patches] ocfs2 update

2008-02-07 Thread Mark Fasheh
On Thu, Feb 07, 2008 at 12:47:45PM -0800, Andrew Morton wrote: > On Thu, 7 Feb 2008 12:09:44 -0800 > Mark Fasheh <[EMAIL PROTECTED]> wrote: > > > /* > > - * dlm_register_domain: one-time setup per "domain" > > + * Compare a requested locking protocol version against the current one. > > + * > > +

Re: [git patches] ocfs2 update

2008-02-07 Thread Andrew Morton
On Thu, 7 Feb 2008 12:09:44 -0800 Mark Fasheh <[EMAIL PROTECTED]> wrote: > /* > - * dlm_register_domain: one-time setup per "domain" > + * Compare a requested locking protocol version against the current one. > + * > + * If the major numbers are different, they are incompatible. > + * If the curr