Re: [alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through

2018-08-09 Thread Mark Brown
On Thu, Aug 09, 2018 at 01:23:58PM +0200, Lars-Peter Clausen wrote: > On 08/09/2018 11:30 AM, Mark Brown wrote: > It is. But it might make sense to re-order the code to look like > > case 5400: > if (source != ADAV80X_PLL_SRC_XIN) > return -EINVAL; > > pll_ctr

Re: [alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through

2018-08-09 Thread Lars-Peter Clausen
On 08/09/2018 11:30 AM, Mark Brown wrote: > On Wed, Aug 08, 2018 at 02:19:33PM -0500, Gustavo A. R. Silva wrote: > >> @@ -648,6 +648,7 @@ static int adav80x_set_pll(struct snd_soc_component >> *component, int pll_id, >> pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV; >>