Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Andrew Cooper
On 02/05/18 16:09, Jan Beulich wrote: On 02.05.18 at 17:08, wrote: >> On 05/02/2018 11:00 AM, Jan Beulich wrote: >> On 02.05.18 at 16:57, wrote: On 05/02/2018 04:05 AM, Jan Beulich wrote: On 30.04.18 at 18:23, wrote: >> Signed-off-by: Boris Ostrovsky > Reviewed-by

Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Jan Beulich
>>> On 02.05.18 at 17:08, wrote: > On 05/02/2018 11:00 AM, Jan Beulich wrote: > On 02.05.18 at 16:57, wrote: >>> On 05/02/2018 04:05 AM, Jan Beulich wrote: >>> On 30.04.18 at 18:23, wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Jan Beulich But to understand wh

Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Boris Ostrovsky
On 05/02/2018 11:00 AM, Jan Beulich wrote: On 02.05.18 at 16:57, wrote: >> On 05/02/2018 04:05 AM, Jan Beulich wrote: >> On 30.04.18 at 18:23, wrote: Signed-off-by: Boris Ostrovsky >>> Reviewed-by: Jan Beulich >>> >>> But to understand why things have been working nevertheless it

Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Jan Beulich
>>> On 02.05.18 at 16:57, wrote: > On 05/02/2018 04:05 AM, Jan Beulich wrote: > On 30.04.18 at 18:23, wrote: >>> Signed-off-by: Boris Ostrovsky >> Reviewed-by: Jan Beulich >> >> But to understand why things have been working nevertheless it would >> have been nice if the commit message wasn

Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Boris Ostrovsky
On 05/02/2018 04:05 AM, Jan Beulich wrote: On 30.04.18 at 18:23, wrote: >> Signed-off-by: Boris Ostrovsky > Reviewed-by: Jan Beulich > > But to understand why things have been working nevertheless it would > have been nice if the commit message wasn't empty, but instead said > something lik

Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode

2018-05-02 Thread Jan Beulich
>>> On 30.04.18 at 18:23, wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Jan Beulich But to understand why things have been working nevertheless it would have been nice if the commit message wasn't empty, but instead said something like "The two happen to be identical on 64-bit." Jan