Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-30 Thread Geert Uytterhoeven
On Sat, 29 Jan 2005, Pierre Ossman wrote: > Christoph Hellwig wrote: > > > > Russell, please undo this patch. isa_virt_to_bus() is not dependent on > > > > CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable > > > > ISA support. > > > > Actually it is, x86_64 just refuses to set

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Pierre Ossman
Christoph Hellwig wrote: On Sat, Jan 29, 2005 at 05:08:32PM +0100, Pierre Ossman wrote: For i386 and x86_64 it's defined as virt_to_phys in asm/io.h without any #ifdef:s protecting it. Not all the world is a PC Then the dependency should in that case be on architectures. It is connecte

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 05:08:32PM +0100, Pierre Ossman wrote: > For i386 and x86_64 it's defined as virt_to_phys in asm/io.h without any > #ifdef:s protecting it. Not all the world is a PC - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Pierre Ossman
Christoph Hellwig wrote: On Sat, Jan 29, 2005 at 04:31:16PM +0100, Pierre Ossman wrote: The problem was that the DMA API didn't work for x86_64 when I wrote the driver. I see now that it has been fixed. isa_virt_to_bus still works even though CONFIG_ISA is not configured. So It may not ex

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 04:31:16PM +0100, Pierre Ossman wrote: > The problem was that the DMA API didn't work for x86_64 when I wrote the > driver. I see now that it has been fixed. > isa_virt_to_bus still works even though CONFIG_ISA is not configured. So It may not exist at all. - To unsubscr

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Pierre Ossman
Christoph Hellwig wrote: Russell, please undo this patch. isa_virt_to_bus() is not dependent on CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable ISA support. Actually it is, x86_64 just refuses to set CONFIG_ISA despite having isa-like devices. Either way a new drive

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 03:13:46PM +, Russell King wrote: > One thing which comes up in this instance is: what struct device should > be used. Current convention is to use a NULL device, it's from pre-generic DMA times were only the pci_* types existed. - To unsubscribe from this list: send t

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Russell King
On Sat, Jan 29, 2005 at 03:00:23PM +, Christoph Hellwig wrote: > Either way a new driver shouldn't use isa_virt_to_bus at all but rather > use the proper DMA API and all those problems go away. One thing which comes up in this instance is: what struct device should be used. With ISA devices d

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 02:54:17PM +, Russell King wrote: > Christoph, did you mean to add anything? Yes, this somehow got lost: - > > Russell, please undo this patch. isa_virt_to_bus() is not dependent on > > CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable > > I

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Russell King
Christoph, did you mean to add anything? On Sat, Jan 29, 2005 at 01:57:14PM +, Christoph Hellwig wrote: > On Sat, Jan 29, 2005 at 02:37:39PM +0100, Pierre Ossman wrote: > > Pierre Ossman wrote: > > >Geert Uytterhoeven wrote: > > > > > >>MMC_WBSD depends on ISA (needs isa_virt_to_bus()) > > >>

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Christoph Hellwig
On Sat, Jan 29, 2005 at 02:37:39PM +0100, Pierre Ossman wrote: > Pierre Ossman wrote: > >Geert Uytterhoeven wrote: > > > >>MMC_WBSD depends on ISA (needs isa_virt_to_bus()) > >> > >> > > > >Thanks. Shouldn't have missed something so obvious :) > > > >Russell, can you fix this in your next merge? >

Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA

2005-01-29 Thread Pierre Ossman
Pierre Ossman wrote: Geert Uytterhoeven wrote: MMC_WBSD depends on ISA (needs isa_virt_to_bus()) Thanks. Shouldn't have missed something so obvious :) Russell, can you fix this in your next merge? Russell, please undo this patch. isa_virt_to_bus() is not dependent on CONFIG_ISA. It causes problem