Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-27 Thread 'Baoquan He'
On 10/27/15 at 09:01am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi, > > > I just have a look at this thread. I am wondering why we don't use > > existing is_kdump_kernel() directly to disable external NMI if it's > > in kdump kernel. Then no need to introduce another boot option "noextnmi" > > which is use

RE: Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-27 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, > I just have a look at this thread. I am wondering why we don't use > existing is_kdump_kernel() directly to disable external NMI if it's > in kdump kernel. Then no need to introduce another boot option "noextnmi" > which is used only for kdump kernel. As I stated in another mail, there is a

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-27 Thread Baoquan He
Hi, I just have a look at this thread. I am wondering why we don't use existing is_kdump_kernel() directly to disable external NMI if it's in kdump kernel. Then no need to introduce another boot option "noextnmi" which is used only for kdump kernel. Thanks Baoquan On 09/25/15 at 08:28pm, Hidehir

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-15 Thread 河合英宏 / KAWAI,HIDEHIRO
> > By the way, I have a pending patch which expands this option like > > this: > > > > apic_extnmi={ bsp | all | none } > > > > If apic_extnmi=all is specified, external NMIs are broadcast to > > all CPUs. This raises the successful rate of kernel panic in the case > > where an external NMI t

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-15 Thread 河合英宏 / KAWAI,HIDEHIRO
> * Thomas Gleixner wrote: > > > Borislav, > > > > On Mon, 5 Oct 2015, Borislav Petkov wrote: > > > On Mon, Oct 05, 2015 at 02:03:58AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > > That's different from my point of view. I'm not going to pass > > > > some data from the first kernel to the second k

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-14 Thread Ingo Molnar
* Thomas Gleixner wrote: > Borislav, > > On Mon, 5 Oct 2015, Borislav Petkov wrote: > > On Mon, Oct 05, 2015 at 02:03:58AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > That's different from my point of view. I'm not going to pass > > > some data from the first kernel to the second kernel. I'm jus

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-13 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Fri, 25 Sep 2015, Hidehiro Kawai wrote: > > > This patch introduces new boot option "noextnmi" which disables > > external NMI. This option is useful for the dump capture kernel > > so that an HA application or administrator wouldn't mistakenly > > shoot down the kernel by NMI. > > > > Curre

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-13 Thread Thomas Gleixner
On Fri, 25 Sep 2015, Hidehiro Kawai wrote: > This patch introduces new boot option "noextnmi" which disables > external NMI. This option is useful for the dump capture kernel > so that an HA application or administrator wouldn't mistakenly > shoot down the kernel by NMI. > > Currently, only x86

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-13 Thread 河合英宏 / KAWAI,HIDEHIRO
Hello, Boris Sorry for the late reply. > On Mon, Oct 05, 2015 at 09:21:02AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > So, the problem for you is that "noextnmi" option is visible and effective > > in the first kernel, isn't it? > > No, such an option shouldn't exist at all. You should be passing >

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-05 Thread Borislav Petkov
On Mon, Oct 05, 2015 at 09:21:02AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > So, the problem for you is that "noextnmi" option is visible and effective > in the first kernel, isn't it? No, such an option shouldn't exist at all. You should be passing information *in* *a* *different* *manner* to the kdu

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-05 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Mon, Oct 05, 2015 at 02:03:58AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > That's different from my point of view. I'm not going to pass > > some data from the first kernel to the second kernel. I'm just going to > > provide a configurable option for the second kernel to users. > > Dude, WTF?!

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-05 Thread Borislav Petkov
On Mon, Oct 05, 2015 at 02:03:58AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > That's different from my point of view. I'm not going to pass > some data from the first kernel to the second kernel. I'm just going to > provide a configurable option for the second kernel to users. Dude, WTF?! You're addin

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-04 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Fri, Oct 02, 2015 at 12:58:02AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > On Thu, Oct 01, 2015 at 10:24:19AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > > But how do we check if the starting kernel is a dump capture kernel? > > > > > > How does that first kernel pass info to the capture kernel?

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-02 Thread Borislav Petkov
On Fri, Oct 02, 2015 at 12:58:02AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > On Thu, Oct 01, 2015 at 10:24:19AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > But how do we check if the starting kernel is a dump capture kernel? > > > > How does that first kernel pass info to the capture kernel? > > As I

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-01 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Thu, Oct 01, 2015 at 10:24:19AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > But how do we check if the starting kernel is a dump capture kernel? > > How does that first kernel pass info to the capture kernel? As I described in the previous mail, You just have to add "noextnmi" to KDUMP_COMMANDLI

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-01 Thread Borislav Petkov
On Thu, Oct 01, 2015 at 10:24:19AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > But how do we check if the starting kernel is a dump capture kernel? How does that first kernel pass info to the capture kernel? > I think using cmdline option is the simplest way. More often than not, simplest != correct.

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-01 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Thu, Oct 01, 2015 at 07:01:50AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > I suppose that a sever which uses this feature will equip a BMC > > and BMC mandatorily supports hard reset command for the server. > > If the HA clustering software detects no response from the server > > after relatively

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-01 Thread Borislav Petkov
On Thu, Oct 01, 2015 at 07:01:50AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > I suppose that a sever which uses this feature will equip a BMC > and BMC mandatorily supports hard reset command for the server. > If the HA clustering software detects no response from the server > after relatively long time

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-10-01 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Thu, Oct 01, 2015 at 02:33:18AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > On Fri, Sep 25, 2015 at 08:28:11PM +0900, Hidehiro Kawai wrote: > > > > This patch introduces new boot option "noextnmi" which disables > > > > external NMI. This option is useful for the dump capture kernel > > > > so

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-09-30 Thread Peter Zijlstra
On Thu, Oct 01, 2015 at 02:33:18AM +, 河合英宏 / KAWAI,HIDEHIRO wrote: > > On Fri, Sep 25, 2015 at 08:28:11PM +0900, Hidehiro Kawai wrote: > > > This patch introduces new boot option "noextnmi" which disables > > > external NMI. This option is useful for the dump capture kernel > > > so that an HA

RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-09-30 Thread 河合英宏 / KAWAI,HIDEHIRO
> On Fri, Sep 25, 2015 at 08:28:11PM +0900, Hidehiro Kawai wrote: > > This patch introduces new boot option "noextnmi" which disables > > external NMI. This option is useful for the dump capture kernel > > so that an HA application or administrator wouldn't mistakenly > > shoot down the kernel by

Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option

2015-09-30 Thread Peter Zijlstra
On Fri, Sep 25, 2015 at 08:28:11PM +0900, Hidehiro Kawai wrote: > This patch introduces new boot option "noextnmi" which disables > external NMI. This option is useful for the dump capture kernel > so that an HA application or administrator wouldn't mistakenly > shoot down the kernel by NMI. So t