Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-25 Thread Alexander Popov
Thanks, Gerhard. I'll improve the code and return with the third version. Best regards, Alexander. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-17 Thread Gerhard Sittig
On Fri, Jul 12, 2013 at 14:42 +0400, Alexander Popov wrote: > > 2013/7/10 Gerhard Sittig : > > On Wed, Jul 10, 2013 at 14:21 +0400, Alexander Popov wrote: > >> > >> + > >> +struct mpc512x_lpbfifo_request { > >> + unsigned int cs; > >> + phys_addr_t bus_phys; /* physical address of some

Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-12 Thread Alexander Popov
Hello Gerhard Thanks for the review. I'll do my best to answer your questions and fix my code. 2013/7/10 Gerhard Sittig : > On Wed, Jul 10, 2013 at 14:21 +0400, Alexander Popov wrote: >> +/* >> + * SCLPC Module (LPB FIFO) >> + */ >> +enum lpb_dev_portsize { >> + LPB_DEV_PORTSIZE_UNDEFINED =

Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-10 Thread Timur Tabi
Gerhard Sittig wrote: >+ * Author is Alexander Popov. nit pick: is 1337 speak usual and appropriate here? Um, that's his actual email address. shouldn't headers get sorted alphabetically? Is that a new policy? I've never heard that requirement. +MODULE_AUTHOR("Alexander Popov "); +MO

Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-10 Thread Rob Herring
On 07/10/2013 08:46 AM, Gerhard Sittig wrote: > On Wed, Jul 10, 2013 at 14:21 +0400, Alexander Popov wrote: >> >> This is SCLPC device driver for the Freescale MPC512x. >> It is needed for Direct Memory Access to the devices on LocalPlus Bus. >> >> Signed-off-by: Alexander Popov >> --- >> arch/po

Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2013-07-10 Thread Gerhard Sittig
On Wed, Jul 10, 2013 at 14:21 +0400, Alexander Popov wrote: > > This is SCLPC device driver for the Freescale MPC512x. > It is needed for Direct Memory Access to the devices on LocalPlus Bus. > > Signed-off-by: Alexander Popov > --- > arch/powerpc/boot/dts/mpc5121.dtsi| 8 +- > ar