Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-14 Thread Maxime Ripard
On Fri, Nov 14, 2014 at 10:19:47AM +0100, Linus Walleij wrote: > On Wed, Oct 29, 2014 at 8:09 AM, Alexandre Courbot wrote: > > On Wed, Oct 22, 2014 at 5:09 AM, Benoit Parrot wrote: > > > + line_b: line_b { > > + line_b { > > + gpi

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-14 Thread Linus Walleij
On Wed, Oct 29, 2014 at 8:09 AM, Alexandre Courbot wrote: > On Wed, Oct 22, 2014 at 5:09 AM, Benoit Parrot wrote: > + line_b: line_b { > + line_b { > + gpios = <6 0>; > + output-low; > +

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-14 Thread Linus Walleij
On Tue, Nov 4, 2014 at 1:38 AM, Benoit Parrot wrote: Sorry for slow replies... > Linus Walleij wrote on Mon [2014-Nov-03 10:59:53 > +0100]: >> On Tue, Oct 21, 2014 at 10:09 PM, Benoit Parrot wrote: >> >> > qe_pio_a: gpio-controller@1400 { >> > @@ -110,6 +130,19 @@ Example of two SOC G

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-03 Thread Benoit Parrot
Linus, Thanks for the feedback. To summarize the hog feature should be local to gpiolib-of.c, correct? I also also need some clarifications, see below. Linus Walleij wrote on Mon [2014-Nov-03 10:59:53 +0100]: > On Tue, Oct 21, 2014 at 10:09 PM, Benoit Parrot wrote: > > > qe_pio_a:

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-03 Thread Linus Walleij
On Tue, Oct 21, 2014 at 10:09 PM, Benoit Parrot wrote: > Based on Boris Brezillion work this is a reworked patch > of his initial GPIO hogging mechanism. > This patch provides a way to initally configure specific GPIO > when the gpio controller is probe. > > The actual DT scanning to collect the

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-11-03 Thread Linus Walleij
On Wed, Oct 29, 2014 at 9:53 AM, Pantelis Antoniou wrote: > 3) I’m not very fond of having this being part of the gpio controller. This > configuration conceptually has little to do with the gpio controller per se, > it is more of a board specific thing. Why not come up with a gpio-hog driver >

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-30 Thread Maxime Ripard
On Wed, Oct 29, 2014 at 06:09:12PM -0500, Benoit Parrot wrote: > Maxime Ripard wrote on Wed [2014-Oct-29 > 17:47:46 +0100]: > > On Wed, Oct 29, 2014 at 11:41:22AM -0500, Benoit Parrot wrote: > > > Maxime Ripard wrote on Wed > > > [2014-Oct-29 11:45:59 +0100]: > > > > Hi, > > > > > > > > On Tue

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Alexandre Courbot
On Thu, Oct 30, 2014 at 1:42 AM, Pantelis Antoniou wrote: > Hi Benoit, > >> On Oct 29, 2014, at 18:34 , Benoit Parrot wrote: >> >> Pantelis, >> >> Thanks for the feedback. >> >> Pantelis Antoniou wrote on Wed [2014-Oct-29 >> 10:53:44 +0200]: >>> Hi Benoit, >>> On Oct 21, 2014, at 23:09 , B

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Alexandre Courbot
On Thu, Oct 30, 2014 at 1:21 AM, Benoit Parrot wrote: >> > + >> > if (status) >> > goto fail; >> > >> > @@ -1742,6 +1757,72 @@ struct gpio_desc *__must_check >> > __gpiod_get_index_optional(struct device *dev, >> > EXPORT_SYMBOL_GPL(__gpiod_get_index_optional); >> > >> >

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Benoit Parrot
Maxime Ripard wrote on Wed [2014-Oct-29 17:47:46 +0100]: > On Wed, Oct 29, 2014 at 11:41:22AM -0500, Benoit Parrot wrote: > > Maxime Ripard wrote on Wed [2014-Oct-29 > > 11:45:59 +0100]: > > > Hi, > > > > > > On Tue, Oct 21, 2014 at 03:09:58PM -0500, Benoit Parrot wrote: > > > > Based on Boris

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Benoit Parrot
Pantelis Antoniou wrote on Wed [2014-Oct-29 18:42:48 +0200]: > Hi Benoit, > > > On Oct 29, 2014, at 18:34 , Benoit Parrot wrote: > > > > Pantelis, > > > > Thanks for the feedback. > > > > Pantelis Antoniou wrote on Wed [2014-Oct-29 > > 10:53:44 +0200]: > >> Hi Benoit, > >> > >>> On Oct 21

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Pantelis Antoniou
Hi Benoit, > On Oct 29, 2014, at 18:34 , Benoit Parrot wrote: > > Pantelis, > > Thanks for the feedback. > > Pantelis Antoniou wrote on Wed [2014-Oct-29 > 10:53:44 +0200]: >> Hi Benoit, >> >>> On Oct 21, 2014, at 23:09 , Benoit Parrot wrote: >>> >>> Based on Boris Brezillion work this is

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Maxime Ripard
On Wed, Oct 29, 2014 at 11:41:22AM -0500, Benoit Parrot wrote: > Maxime Ripard wrote on Wed [2014-Oct-29 > 11:45:59 +0100]: > > Hi, > > > > On Tue, Oct 21, 2014 at 03:09:58PM -0500, Benoit Parrot wrote: > > > Based on Boris Brezillion work this is a reworked patch > > > of his initial GPIO hoggi

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Benoit Parrot
Maxime Ripard wrote on Wed [2014-Oct-29 11:45:59 +0100]: > Hi, > > On Tue, Oct 21, 2014 at 03:09:58PM -0500, Benoit Parrot wrote: > > Based on Boris Brezillion work this is a reworked patch > > of his initial GPIO hogging mechanism. > > This patch provides a way to initally configure specific GP

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Benoit Parrot
Pantelis, Thanks for the feedback. Pantelis Antoniou wrote on Wed [2014-Oct-29 10:53:44 +0200]: > Hi Benoit, > > > On Oct 21, 2014, at 23:09 , Benoit Parrot wrote: > > > > Based on Boris Brezillion work this is a reworked patch > > of his initial GPIO hogging mechanism. > > This patch provid

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Benoit Parrot
Alexandre, Thanks for the feedback. Alexandre Courbot wrote on Wed [2014-Oct-29 16:09:59 +0900]: > Sorry for the delay in reviewing. Adding Jiri and Pantelis who might > want to extend over this patch and thus will likely have interesting > comments to make. > > On Wed, Oct 22, 2014 at 5:09 AM,

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Maxime Ripard
Hi, On Tue, Oct 21, 2014 at 03:09:58PM -0500, Benoit Parrot wrote: > Based on Boris Brezillion work this is a reworked patch > of his initial GPIO hogging mechanism. > This patch provides a way to initally configure specific GPIO > when the gpio controller is probe. > > The actual DT scanning to

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Pantelis Antoniou
Hi Benoit, > On Oct 21, 2014, at 23:09 , Benoit Parrot wrote: > > Based on Boris Brezillion work this is a reworked patch > of his initial GPIO hogging mechanism. > This patch provides a way to initally configure specific GPIO > when the gpio controller is probe. > > The actual DT scanning to c

Re: [RFC Patch] gpio: add GPIO hogging mechanism

2014-10-29 Thread Alexandre Courbot
Sorry for the delay in reviewing. Adding Jiri and Pantelis who might want to extend over this patch and thus will likely have interesting comments to make. On Wed, Oct 22, 2014 at 5:09 AM, Benoit Parrot wrote: > Based on Boris Brezillion work this is a reworked patch > of his initial GPIO hogging

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-10-21 Thread Linus Walleij
On Mon, Oct 6, 2014 at 5:37 PM, Benoit Parrot wrote: > I do have a modified version of Boris' first patch addressing your original > comments which I am planning to submit if you it is still a valid idea. Please do whatever we end up merging or not, sharing code is always a good idea. Don't forg

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-10-06 Thread Benoit Parrot
Linus, Sorry about the resend, but i just realized i should have copied you directly on the follow-up. Please let me know what you think. I do have a modified version of Boris' first patch addressing your original comments which I am planning to submit if you it is still a valid idea. Regards,

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-09-20 Thread Ben Gamari
Ben Gamari writes: > Hi Boris, > > I'm just returning to this now. > > > Greg Kroah-Hartman writes: > >> I don't understand what makes GPIO's "special" enough to get included in >> the driver core like this, and called for each and every device that is >> added to the system. >> > I'm also a bit

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-09-20 Thread Ben Gamari
Hi Boris, I'm just returning to this now. Greg Kroah-Hartman writes: > I don't understand what makes GPIO's "special" enough to get included in > the driver core like this, and called for each and every device that is > added to the system. > I'm also a bit confused why GPIOs ended up in the d

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-01-14 Thread Linus Walleij
On Wed, Jan 8, 2014 at 11:18 AM, boris brezillon wrote: > Anyway, do you want me to rework the gpio hog as described below ? If you feel you have time, drive and a proper usecase for testing it, sure. I just want it to be driven my someone who *really* needs that feature. Yours, Linus Walleij -

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-01-08 Thread boris brezillon
On 08/01/2014 10:37, Linus Walleij wrote: On Thu, Dec 19, 2013 at 3:34 PM, Boris BREZILLON wrote: GPIO hogging is a way to request and configure specific GPIO without explicitly requesting it in the device driver. The request and configuration procedure is handled in the core device driver co

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-01-08 Thread Linus Walleij
On Mon, Dec 30, 2013 at 10:48 AM, boris brezillon wrote: > On 19/12/2013 19:22, Felipe Balbi wrote: >> that's quite a weird argument from Linus W, considering you _do_ have a >> discrete mux on the board. > >> We have quite a few of such "crazy" scenarios here at TI and we were >> going to send a

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-01-08 Thread Linus Walleij
On Thu, Dec 19, 2013 at 3:34 PM, Boris BREZILLON wrote: > GPIO hogging is a way to request and configure specific GPIO without > explicitly requesting it in the device driver. > > The request and configuration procedure is handled in the core device > driver code before the driver probe function

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-30 Thread boris brezillon
Hello, On 19/12/2013 19:22, Felipe Balbi wrote: On Thu, Dec 19, 2013 at 06:18:40PM +0100, boris brezillon wrote: Hello Felipe, On 19/12/2013 17:47, Felipe Balbi wrote: On Thu, Dec 19, 2013 at 08:41:09AM -0800, Greg Kroah-Hartman wrote: On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLO

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 06:18:40PM +0100, boris brezillon wrote: > Hello Felipe, > > On 19/12/2013 17:47, Felipe Balbi wrote: > >On Thu, Dec 19, 2013 at 08:41:09AM -0800, Greg Kroah-Hartman wrote: > >>On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote: > >>>GPIO hogging is a way to re

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-19 Thread boris brezillon
Hello Greg, On 19/12/2013 17:41, Greg Kroah-Hartman wrote: On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote: GPIO hogging is a way to request and configure specific GPIO without explicitly requesting it in the device driver. The request and configuration procedure is handled in

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-19 Thread boris brezillon
Hello Felipe, On 19/12/2013 17:47, Felipe Balbi wrote: On Thu, Dec 19, 2013 at 08:41:09AM -0800, Greg Kroah-Hartman wrote: On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote: GPIO hogging is a way to request and configure specific GPIO without explicitly requesting it in the devic

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 08:41:09AM -0800, Greg Kroah-Hartman wrote: > On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote: > > GPIO hogging is a way to request and configure specific GPIO without > > explicitly requesting it in the device driver. > > > > The request and configuration p

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2013-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote: > GPIO hogging is a way to request and configure specific GPIO without > explicitly requesting it in the device driver. > > The request and configuration procedure is handled in the core device > driver code before the driver probe f