Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-02-01 Thread Michal Vokáč
Hi Uwe, On 30. 01. 19 16:39, Uwe Kleine-König wrote: On Wed, Jan 30, 2019 at 03:42:29PM +0100, Michal Vokáč wrote: [...]> There are quite some drivers known (to me) being buggy here. My feeling is that Thierry doesn't share that impression and I think the only reasonable path forward is to fir

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-30 Thread Uwe Kleine-König
Hello Michal, On Wed, Jan 30, 2019 at 03:42:29PM +0100, Michal Vokáč wrote: > On 24.1.2019 11:44, Uwe Kleine-König wrote: > > On Thu, Jan 24, 2019 at 11:12:12AM +0100, Michal Vokáč wrote: > > > On 24.1.2019 10:22, Uwe Kleine-König wrote: > > > > I think it might be beneficial to allow (or require)

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-30 Thread Michal Vokáč
On 24.1.2019 11:44, Uwe Kleine-König wrote: On Thu, Jan 24, 2019 at 11:12:12AM +0100, Michal Vokáč wrote: On 24.1.2019 10:22, Uwe Kleine-König wrote: I think it might be beneficial to allow (or require) that disable acts immediately. But this is not how it used to be and in my discussion with T

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-24 Thread Uwe Kleine-König
On Thu, Jan 24, 2019 at 11:12:12AM +0100, Michal Vokáč wrote: > On 24.1.2019 10:22, Uwe Kleine-König wrote: > > I think it might be beneficial to allow (or require) that disable acts > > immediately. But this is not how it used to be and in my discussion with > > Thierry (IIRC) he required to compl

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-24 Thread Michal Vokáč
On 24.1.2019 10:22, Uwe Kleine-König wrote: On Thu, Jan 24, 2019 at 09:59:47AM +0100, Michal Vokáč wrote: On 12.12.2018 13:12, Uwe Kleine-König wrote: On Wed, Dec 12, 2018 at 11:42:17AM +, Vokáč Michal wrote: On 12.12.2018 09:01, Uwe Kleine-König wrote: On Thu, Dec 06, 2018 at 01:41:31PM

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-24 Thread Uwe Kleine-König
On Thu, Jan 24, 2019 at 09:59:47AM +0100, Michal Vokáč wrote: > On 12.12.2018 13:12, Uwe Kleine-König wrote: > > On Wed, Dec 12, 2018 at 11:42:17AM +, Vokáč Michal wrote: > > > On 12.12.2018 09:01, Uwe Kleine-König wrote: > > > > On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > >

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2019-01-24 Thread Michal Vokáč
On 12.12.2018 13:12, Uwe Kleine-König wrote: On Wed, Dec 12, 2018 at 11:42:17AM +, Vokáč Michal wrote: On 12.12.2018 09:01, Uwe Kleine-König wrote: On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: Normally the PWM output is held LOW when PWM is disabled. This can cause problem

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-12 Thread Uwe Kleine-König
On Wed, Dec 12, 2018 at 11:42:17AM +, Vokáč Michal wrote: > On 12.12.2018 09:01, Uwe Kleine-König wrote: > > On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > >> Normally the PWM output is held LOW when PWM is disabled. This can cause > >> problems when inverted PWM signal polarit

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-12 Thread Vokáč Michal
On 12.12.2018 09:01, Uwe Kleine-König wrote: > On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: >> Normally the PWM output is held LOW when PWM is disabled. This can cause >> problems when inverted PWM signal polarity is needed. With this behavior >> the connected circuit is fed by 100

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-12 Thread Uwe Kleine-König
Hello, On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > Normally the PWM output is held LOW when PWM is disabled. This can cause > problems when inverted PWM signal polarity is needed. With this behavior > the connected circuit is fed by 100% duty cycle instead of being shut-off. >

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-10 Thread Vokáč Michal
On 10.12.2018 12:17, Uwe Kleine-König wrote: > On Mon, Dec 10, 2018 at 11:15:05AM +, Vokáč Michal wrote: >> On 6.12.2018 17:16, Uwe Kleine-König wrote: >>> On Thu, Dec 06, 2018 at 03:37:55PM +, Vokáč Michal wrote: On 6.12.2018 14:59, Uwe Kleine-König wrote: > On Thu, Dec 06, 2018 a

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-10 Thread Uwe Kleine-König
On Mon, Dec 10, 2018 at 11:15:05AM +, Vokáč Michal wrote: > On 6.12.2018 17:16, Uwe Kleine-König wrote: > > On Thu, Dec 06, 2018 at 03:37:55PM +, Vokáč Michal wrote: > >> On 6.12.2018 14:59, Uwe Kleine-König wrote: > >>> On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > >>> >

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-10 Thread Vokáč Michal
On 6.12.2018 17:16, Uwe Kleine-König wrote: > On Thu, Dec 06, 2018 at 03:37:55PM +, Vokáč Michal wrote: >> On 6.12.2018 14:59, Uwe Kleine-König wrote: >>> On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: >>> >>> Can it happen, that pinctrl_pins_pwm is PTR_ERR(-EPROBE_DEFER)? >> >>

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-06 Thread Uwe Kleine-König
On Thu, Dec 06, 2018 at 03:37:55PM +, Vokáč Michal wrote: > On 6.12.2018 14:59, Uwe Kleine-König wrote: > > On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > >> +{ > >> + imx_chip->pinctrl = devm_pinctrl_get(&pdev->dev); > >> + if (IS_ERR(imx_chip->pinctrl)) { > >> + de

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-06 Thread Vokáč Michal
On 6.12.2018 14:59, Uwe Kleine-König wrote: > On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: >> >> +static int imx_pwm_init_pinctrl_info(struct imx_chip *imx_chip, >> +struct platform_device *pdev) > > Please indent the follow up line to the opening parenthesis. Meh,

Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-12-06 Thread Uwe Kleine-König
On Thu, Dec 06, 2018 at 01:41:31PM +, Vokáč Michal wrote: > Normally the PWM output is held LOW when PWM is disabled. This can cause > problems when inverted PWM signal polarity is needed. With this behavior > the connected circuit is fed by 100% duty cycle instead of being shut-off. > > Allow