Re: [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output

On 7/7/15 4:43 AM, He Kuang wrote: + F_STRUCT( + __field(long, size) as Peter said please use u32 to avoid 32 vs 64-bit issues. + __array(u64,raw_data, TRACE_BPF_MAX_ENTRY) + ), + + F_printk("%ld: (%016llx, ...)", __entry->size, __entr

Re: [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output

On Tue, Jul 07, 2015 at 11:43:05AM +, He Kuang wrote: > +FTRACE_ENTRY_REG(bpf, trace_bpf, > + > + TRACE_BPF, > + > + F_STRUCT( > + __field(long, size) I would suggest using either u32 or u64, not a variable size type like long. > + __array(u64,raw_data,