Re: [RFC PATCH v3 01/16] stop_machine: Fix stop_cpus_in_progress ordering

2019-08-26 Thread Peter Zijlstra
On Mon, Aug 26, 2019 at 09:19:31AM -0700, mark gross wrote: > On Wed, May 29, 2019 at 08:36:37PM +, Vineeth Remanan Pillai wrote: > > From: Peter Zijlstra > > > > Make sure the entire for loop has stop_cpus_in_progress set. > It is not clear how this commit comment matches the change. Please

Re: [RFC PATCH v3 01/16] stop_machine: Fix stop_cpus_in_progress ordering

2019-08-26 Thread mark gross
On Wed, May 29, 2019 at 08:36:37PM +, Vineeth Remanan Pillai wrote: > From: Peter Zijlstra > > Make sure the entire for loop has stop_cpus_in_progress set. It is not clear how this commit comment matches the change. Please explain how adding 2 barrier's makes sure stop_cpus_in_progress is se