Re: [RFC PATCH v2 0/4] make jbd2 debug switch per device

2021-01-28 Thread brookxu
Theodore Ts'o wrote on 2021/1/28 0:21: > On Tue, Jan 26, 2021 at 08:50:02AM +0800, brookxu wrote: >> >> trace point, eBPF and other hook technologies are better for production >> environments. But for pure debugging work, adding hook points feels a bit >> heavy. However, your suggestion is very

Re: [RFC PATCH v2 0/4] make jbd2 debug switch per device

2021-01-27 Thread Theodore Ts'o
On Tue, Jan 26, 2021 at 08:50:02AM +0800, brookxu wrote: > > trace point, eBPF and other hook technologies are better for production > environments. But for pure debugging work, adding hook points feels a bit > heavy. However, your suggestion is very valuable, thank you very much. What feels heav

Re: [RFC PATCH v2 0/4] make jbd2 debug switch per device

2021-01-26 Thread brookxu
Theodore Ts'o wrote on 2021/1/26 5:50: > On Sat, Jan 23, 2021 at 08:00:42PM +0800, Chunguang Xu wrote: >> On a multi-disk machine, because jbd2 debugging switch is global, this >> confuses the logs of multiple disks. It is not easy to distinguish the >> logs of each disk and the amount of genera

Re: [RFC PATCH v2 0/4] make jbd2 debug switch per device

2021-01-25 Thread Theodore Ts'o
On Sat, Jan 23, 2021 at 08:00:42PM +0800, Chunguang Xu wrote: > On a multi-disk machine, because jbd2 debugging switch is global, this > confuses the logs of multiple disks. It is not easy to distinguish the > logs of each disk and the amount of generated logs is very large. Maybe > a separate debu