Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-03-04 Thread Sergey Senozhatsky
On (02/26/19 16:22), John Ogness wrote: > > This looks like an alien. The code is supposed to write one message > > from the given buffer. And some huge job is well hidden there. > > This is a very simple implementation of a printk kthread. It probably > makes more sense to have a printk kthread p

Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-02-27 Thread Petr Mladek
On Wed 2019-02-27 11:02:53, John Ogness wrote: > On 2019-02-27, Petr Mladek wrote: > > I mean that your patch does the reply on a very hidden location. > > Right. I understand that and I agree. > > > Regarding the per-console kthread. It would make sense if > > we stop handling all consoles sync

Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-02-27 Thread John Ogness
On 2019-02-27, Petr Mladek wrote: > I mean that your patch does the reply on a very hidden location. Right. I understand that and I agree. > Regarding the per-console kthread. It would make sense if > we stop handling all consoles synchronously. For example, > when we push messages to fast conso

Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-02-27 Thread Petr Mladek
On Tue 2019-02-26 16:22:01, John Ogness wrote: > On 2019-02-26, Petr Mladek wrote: > >> When new consoles register, they currently print how many messages > >> they have missed. However, many (or all) of those messages may still > >> be in the ring buffer. Add functionality to print as much of the

Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-02-26 Thread John Ogness
On 2019-02-26, Petr Mladek wrote: >> When new consoles register, they currently print how many messages >> they have missed. However, many (or all) of those messages may still >> be in the ring buffer. Add functionality to print as much of the >> history as available. This is a clean replacement o

Re: [RFC PATCH v1 15/25] printk: print history for new consoles

2019-02-26 Thread Petr Mladek
On Tue 2019-02-12 15:29:53, John Ogness wrote: > When new consoles register, they currently print how many messages > they have missed. However, many (or all) of those messages may still > be in the ring buffer. Add functionality to print as much of the > history as available. This is a clean repla