Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-20 Thread Jason Cooper
Hey Sebastian, On Wed, Jul 20, 2016 at 01:42:45PM +0200, Sebastian Frias wrote: > On 07/06/2016 06:28 PM, Jason Cooper wrote: > > On Wed, Jul 06, 2016 at 01:37:21PM +0200, Sebastian Frias wrote: > >> On 07/05/2016 06:16 PM, Jason Cooper wrote: > Come to think of it, I'm not sure the *name* of

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-20 Thread Sebastian Frias
Hi Jason, On 07/06/2016 06:28 PM, Jason Cooper wrote: > Hi Sebastian, > > On Wed, Jul 06, 2016 at 01:37:21PM +0200, Sebastian Frias wrote: >> On 07/05/2016 06:16 PM, Jason Cooper wrote: Come to think of it, I'm not sure the *name* of the file documenting a binding is as important to DT

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-07 Thread Marc Zyngier
On 07/07/16 13:16, Sebastian Frias wrote: > Hi Marc, > > On 07/06/2016 03:50 PM, Marc Zyngier wrote: >>> I think that's where part the misunderstanding comes from. >>> IMHO the output line is not a direct function of the input line. >>> Any of the 64 IRQ lines entering the "old controller" (irq-ta

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-07 Thread Sebastian Frias
Hi Marc, On 07/06/2016 03:50 PM, Marc Zyngier wrote: >> I think that's where part the misunderstanding comes from. >> IMHO the output line is not a direct function of the input line. >> Any of the 64 IRQ lines entering the "old controller" (irq-tango.c) can be >> routed to any of its 3 outputs. >

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Jason Cooper
On Wed, Jul 06, 2016 at 11:30:48AM +0200, Thomas Gleixner wrote: > On Wed, 6 Jul 2016, Marc Zyngier wrote: > > On 05/07/16 20:24, Thomas Gleixner wrote: > > > On Tue, 5 Jul 2016, Marc Zyngier wrote: > > >> Hardcoded? No way. You simply implement a route allocator in your > > >> driver, assigning th

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Jason Cooper
Hi Sebastian, On Wed, Jul 06, 2016 at 01:37:21PM +0200, Sebastian Frias wrote: > On 07/05/2016 06:16 PM, Jason Cooper wrote: > >> Come to think of it, I'm not sure the *name* of the file documenting > >> a binding is as important to DT maintainers as the compatible string. > > > > Correct. devic

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Marc Zyngier
On 06/07/16 11:49, Sebastian Frias wrote: > Hi, > > On 07/06/2016 11:30 AM, Thomas Gleixner wrote: >> On Wed, 6 Jul 2016, Marc Zyngier wrote: >>> On 05/07/16 20:24, Thomas Gleixner wrote: On Tue, 5 Jul 2016, Marc Zyngier wrote: > Hardcoded? No way. You simply implement a route allocator i

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Marc Zyngier
On 06/07/16 11:47, Sebastian Frias wrote: >>> I think I'm missing something, what is the difference between the domains >>> described by nodes in the DT for irq-tango.c >>> (arch/arm/boot/dts/tango4-common.dtsi) >>> and the DT from my RFC? >> >> The fundamental difference is that with your new fa

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Sebastian Frias
Hi Jason, On 07/05/2016 06:16 PM, Jason Cooper wrote: >> Come to think of it, I'm not sure the *name* of the file documenting >> a binding is as important to DT maintainers as the compatible string. > > Correct. devicetee compatible strings need to be as specific as > possible. Specific with

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Sebastian Frias
Hi, On 07/06/2016 11:30 AM, Thomas Gleixner wrote: > On Wed, 6 Jul 2016, Marc Zyngier wrote: >> On 05/07/16 20:24, Thomas Gleixner wrote: >>> On Tue, 5 Jul 2016, Marc Zyngier wrote: Hardcoded? No way. You simply implement a route allocator in your driver, assigning them as needed. And ye

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Sebastian Frias
Hi Marc, On 07/05/2016 07:13 PM, Marc Zyngier wrote: >>> You really don't need to describe this. The configuration that is >>> applied to your router in entirely under software control, >> >> With "entirely under software control" do you mean this driver's code? > > Yes. Ok. > >> >>> and none

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Thomas Gleixner
On Wed, 6 Jul 2016, Marc Zyngier wrote: > On 05/07/16 20:24, Thomas Gleixner wrote: > > On Tue, 5 Jul 2016, Marc Zyngier wrote: > >> Hardcoded? No way. You simply implement a route allocator in your > >> driver, assigning them as needed. And yes, if you have more than 24 > >> interrupts, they get m

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-06 Thread Marc Zyngier
On 05/07/16 20:24, Thomas Gleixner wrote: > On Tue, 5 Jul 2016, Marc Zyngier wrote: >> On 05/07/16 17:59, Sebastian Frias wrote: >>> Well, if you the domains should not be described in the DT and that they >>> should >>> be somehow hardcoded into the drivers' code, it should not be hard indeed. >>

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Thomas Gleixner
On Tue, 5 Jul 2016, Marc Zyngier wrote: > On 05/07/16 17:59, Sebastian Frias wrote: > > Well, if you the domains should not be described in the DT and that they > > should > > be somehow hardcoded into the drivers' code, it should not be hard indeed. > > Hardcoded? No way. You simply implement a

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Marc Zyngier
On 05/07/16 17:59, Sebastian Frias wrote: > Hi Marc, > > On 07/05/2016 06:48 PM, Marc Zyngier wrote: >>> I already did something like that, you can see it here: >>> >>> https://marc.info/?l=linux-kernel&m=146592235919308&w=2 >>> >>> the problem with that code is that it cannot handle more than 24

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Sebastian Frias
Hi Marc, On 07/05/2016 06:48 PM, Marc Zyngier wrote: >> I already did something like that, you can see it here: >> >> https://marc.info/?l=linux-kernel&m=146592235919308&w=2 >> >> the problem with that code is that it cannot handle more than 24 IRQs (the >> number of outputs of the router), becaus

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Marc Zyngier
On 05/07/16 17:38, Sebastian Frias wrote: > Hi Jason, > > On 07/05/2016 05:53 PM, Jason Cooper wrote: >>> >>> Thanks for your comments. >>> So, aside from some naming issues, do you think the driver is ok? >> >> Well, it's going to be few days before I can really dig in to this. >> Until then, wha

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Sebastian Frias
Hi Jason, On 07/05/2016 05:53 PM, Jason Cooper wrote: >> >> Thanks for your comments. >> So, aside from some naming issues, do you think the driver is ok? > > Well, it's going to be few days before I can really dig in to this. > Until then, what I can say I see is that it looks like you're using

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Jason Cooper
Hi Mason, On Tue, Jul 05, 2016 at 05:07:09PM +0200, Mason wrote: > Jason Cooper wrote: > > Sebastian Frias wrote: > >> Mason wrote: > >>> Sebastian Frias wrote: > >>> > .../sigma,smp87xx-irqrouter.txt| 69 +++ > >>> > >>> In the *actual* submission, we can't use a wildcar

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Jason Cooper
Hey Sebastian, On Tue, Jul 05, 2016 at 05:18:42PM +0200, Sebastian Frias wrote: > On 07/05/2016 04:41 PM, Jason Cooper wrote: > > On Tue, Jul 05, 2016 at 02:30:12PM +0200, Sebastian Frias wrote: > >> On 07/04/2016 02:11 PM, Mason wrote: > > ... > .../sigma,smp87xx-irqrouter.txt

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Sebastian Frias
Hi Jason, On 07/05/2016 04:41 PM, Jason Cooper wrote: > Hey Sebastian, Mason, > > * Please fix mailer to wrap text at a sane length. I've re-wrapped and > trimmed. > > On Tue, Jul 05, 2016 at 02:30:12PM +0200, Sebastian Frias wrote: >> On 07/04/2016 02:11 PM, Mason wrote: > ... .../sigma,

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Mason
Jason Cooper wrote: > Sebastian Frias wrote: > >> Mason wrote: >> >>> Sebastian Frias wrote: >>> .../sigma,smp87xx-irqrouter.txt| 69 +++ >>> >>> In the *actual* submission, we can't use a wildcard like smp87xx >>> we'll have to use an actual part number. >> >> Are you su

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Jason Cooper
Hey Sebastian, Mason, * Please fix mailer to wrap text at a sane length. I've re-wrapped and trimmed. On Tue, Jul 05, 2016 at 02:30:12PM +0200, Sebastian Frias wrote: > On 07/04/2016 02:11 PM, Mason wrote: ... > >> .../sigma,smp87xx-irqrouter.txt| 69 +++ > > > > In the *ac

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-05 Thread Sebastian Frias
On 07/04/2016 02:11 PM, Mason wrote: > > In the patch subject, do you mean SMP as in Symmetric Multi Processor? As in Sigma Multimedia Processor :-) The prefix for Sigma's chips is SMP. I can change that to "Tango" if it is confusing. > > Is that the address you intend to submit with? Yes. >

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-04 Thread Mason
On 30/06/2016 18:03, Sebastian Frias wrote: > This adds support for a second-gen irq router/controller present > on some Sigma Designs chips. In the patch subject, do you mean SMP as in Symmetric Multi Processor? > Signed-off-by: Sebastian Frias Is that the address you intend to submit with?