Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-04 Thread Arnd Bergmann
On Monday 03 February 2014, Jason Gunthorpe wrote: > On Mon, Feb 03, 2014 at 09:12:32PM +0100, Arnd Bergmann wrote: > > > Are you sure that is true for the root bridge as well? I don't > > remember the details, but I though that for the host bridge, > > we don't actually look at the BARs at all. >

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Jason Gunthorpe
On Mon, Feb 03, 2014 at 09:12:32PM +0100, Arnd Bergmann wrote: > Are you sure that is true for the root bridge as well? I don't > remember the details, but I though that for the host bridge, > we don't actually look at the BARs at all. That is right, but this isn't a host bridge device, it is a P

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Tanmay Inamdar
On Mon, Feb 3, 2014 at 12:12 PM, Arnd Bergmann wrote: > On Monday 03 February 2014 11:42:22 Tanmay Inamdar wrote: >> On Thu, Jan 30, 2014 at 6:16 AM, Arnd Bergmann wrote: >> > On Friday 24 January 2014, Tanmay Inamdar wrote: >> > >> >> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) >>

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Arnd Bergmann
On Monday 03 February 2014 11:42:22 Tanmay Inamdar wrote: > On Thu, Jan 30, 2014 at 6:16 AM, Arnd Bergmann wrote: > > On Friday 24 January 2014, Tanmay Inamdar wrote: > > > >> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) > >> +{ > >> + int i; > >> + > >> + /* Hide the PCI host

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Tanmay Inamdar
On Thu, Jan 30, 2014 at 6:16 AM, Arnd Bergmann wrote: > On Friday 24 January 2014, Tanmay Inamdar wrote: > >> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) >> +{ >> + int i; >> + >> + /* Hide the PCI host BARs from the kernel as their content doesn't >> + * fit well in the

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-01-30 Thread Arnd Bergmann
On Friday 24 January 2014, Tanmay Inamdar wrote: > +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) > +{ > + int i; > + > + /* Hide the PCI host BARs from the kernel as their content doesn't > + * fit well in the resource management > + */ > + for (i = 0; i < DEVICE_