Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-06-02 Thread Sakari Ailus
Hi Janusz, On Sun, Jun 02, 2019 at 11:58:23AM +0200, Janusz Krzysztofik wrote: > Hi Sakari, > > On Sunday, June 2, 2019 12:37:55 AM CEST Sakari Ailus wrote: > > > > ... I realised that the subtle effect of "media: > > ov6650: Register with asynchronous subdevice framework" is that the driver > >

Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-06-02 Thread Janusz Krzysztofik
Hi Sakari, On Sunday, June 2, 2019 12:37:55 AM CEST Sakari Ailus wrote: > > ... I realised that the subtle effect of "media: > ov6650: Register with asynchronous subdevice framework" is that the driver > is now responsible for serialising the access to its own data structures > now. Indeed, I m

Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-06-01 Thread Sakari Ailus
Hi Janusz, On Fri, May 31, 2019 at 07:56:33PM +0200, Janusz Krzysztofik wrote: > Hi Sakari, > > On Friday, May 31, 2019 1:42:58 PM CEST Sakari Ailus wrote: > > Hi Janusz, > > > > On Sun, May 26, 2019 at 10:47:57PM +0200, Janusz Krzysztofik wrote: > > > According to V4L2 subdevice interface speci

Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-05-31 Thread Janusz Krzysztofik
Hi Sakari, On Friday, May 31, 2019 1:42:58 PM CEST Sakari Ailus wrote: > Hi Janusz, > > On Sun, May 26, 2019 at 10:47:57PM +0200, Janusz Krzysztofik wrote: > > According to V4L2 subdevice interface specification, frame scaling > > factors should be reset to default values on modification of input

Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop

2019-05-31 Thread Sakari Ailus
Hi Janusz, On Sun, May 26, 2019 at 10:47:57PM +0200, Janusz Krzysztofik wrote: > According to V4L2 subdevice interface specification, frame scaling > factors should be reset to default values on modification of input frame > format. Assuming that requirement also applies in case of crop > rectang