Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: > Ian Kent writes: > > > On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: > >> n Tue, 25 Nov 2014, Eric W. Biederman wrote: > >> Hi, > >> > >> > Ian Kent writes: > >> > > >> > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. B

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: > > >> > Those are the general parameters. > >> > >> It does seem very expensive to keep a thread around for every mount; I'm > >> still trying to find a way around it.. > > > > Yeah, that's not such a good idea. > > > > Several hundred

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Benjamin Coddington
On Wed, 3 Dec 2014, Eric W. Biederman wrote: > Ian Kent writes: > > > On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: > >> n Tue, 25 Nov 2014, Eric W. Biederman wrote: > >> Hi, > >> > >> > Ian Kent writes: > >> > > >> > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Eric W. Biederman
Ian Kent writes: > On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: >> n Tue, 25 Nov 2014, Eric W. Biederman wrote: >> Hi, >> >> > Ian Kent writes: >> > >> > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: >> > >> Ian Kent writes: >> > >> >> > >> > On Tue, 2014-11-25

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-02 Thread Ian Kent
On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: > n Tue, 25 Nov 2014, Eric W. Biederman wrote: > Hi, > > > Ian Kent writes: > > > > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: > > >> Ian Kent writes: > > >> > > >> > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biede

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-01 Thread Benjamin Coddington
n Tue, 25 Nov 2014, Eric W. Biederman wrote: Hi, > Ian Kent writes: > > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: > >> Ian Kent writes: > >> > >> > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: > >> >> Oleg Nesterov writes: > >> >> > >> >> > On 11/25, Oleg Nest

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-27 Thread Ian Kent
On Tue, 2014-11-25 at 17:27 -0600, Eric W. Biederman wrote: > > > How does one correctly set the namespace in user space since each of > > the /proc//ns/ will use a slightly different > > proc_ns_operations install function? > > > > Are we saying that, for example, if open(/proc//ns/pid)/setns()

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-26 Thread Oleg Nesterov
I didn't have time to follow this thread today, will try tomorrow. Perhaps this was already answered... On 11/26, Ian Kent wrote: > > On Tue, 2014-11-25 at 22:52 +0100, Oleg Nesterov wrote: > > > > and probably we also need this for coredump helpers, we want them > > to be per-namespace. > > To sa

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-26 Thread J. Bruce Fields
On Wed, Nov 26, 2014 at 09:00:11AM -0600, Eric W. Biederman wrote: > David Howells writes: > > > Eric W. Biederman wrote: > > > >> Ian if we were to merge this I believe you would win the award for > >> easiest path to a root shell. > > > > Is there any particular reason the upcalled program has

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-26 Thread Eric W. Biederman
David Howells writes: > Eric W. Biederman wrote: > >> Ian if we were to merge this I believe you would win the award for >> easiest path to a root shell. > > Is there any particular reason the upcalled program has to be run as root? > Could the kernel not run it as something else - perhaps the c

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-26 Thread David Howells
Eric W. Biederman wrote: > Ian if we were to merge this I believe you would win the award for > easiest path to a root shell. Is there any particular reason the upcalled program has to be run as root? Could the kernel not run it as something else - perhaps the caller's UID,GID or even something

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Eric W. Biederman
Ian Kent writes: > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: >> Ian Kent writes: >> >> > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: >> >> Oleg Nesterov writes: >> >> >> >> > On 11/25, Oleg Nesterov wrote: >> >> >> >> >> >> Let me first apologize, I didn't ac

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Wed, 2014-11-26 at 07:50 +0800, Ian Kent wrote: > > > > If we are going to set this stuff up in the kernel we need a reference > > process that we can create children of because what is possible with > > respect to containers keeps changing, and it is extremely error prone to > > figure out wha

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: > Ian Kent writes: > > > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: > >> Oleg Nesterov writes: > >> > >> > On 11/25, Oleg Nesterov wrote: > >> >> > >> >> Let me first apologize, I didn't actually read this series yet.

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Eric W. Biederman
Ian Kent writes: > On Tue, 2014-11-25 at 22:52 +0100, Oleg Nesterov wrote: >> Let me first apologize, I didn't actually read this series yet. >> >> But I have to admit that so far I do not like this approach... >> probably I am biased. > > Oleg, thanks for your comments. > >> >> On 11/25, Ian K

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Eric W. Biederman
Ian Kent writes: > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: >> Oleg Nesterov writes: >> >> > On 11/25, Oleg Nesterov wrote: >> >> >> >> Let me first apologize, I didn't actually read this series yet. >> >> >> >> But I have to admit that so far I do not like this approach... >

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 23:06 +0100, Oleg Nesterov wrote: > On 11/25, Oleg Nesterov wrote: > > > > Let me first apologize, I didn't actually read this series yet. > > > > But I have to admit that so far I do not like this approach... > > probably I am biased. > > Yes. > > And I have another concern

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: > Oleg Nesterov writes: > > > On 11/25, Oleg Nesterov wrote: > >> > >> Let me first apologize, I didn't actually read this series yet. > >> > >> But I have to admit that so far I do not like this approach... > >> probably I am biased. >

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 22:52 +0100, Oleg Nesterov wrote: > Let me first apologize, I didn't actually read this series yet. > > But I have to admit that so far I do not like this approach... > probably I am biased. Oleg, thanks for your comments. > > On 11/25, Ian Kent wrote: > > > > The call_use

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Eric W. Biederman
Oleg Nesterov writes: > On 11/25, Oleg Nesterov wrote: >> >> Let me first apologize, I didn't actually read this series yet. >> >> But I have to admit that so far I do not like this approach... >> probably I am biased. > > Yes. > > And I have another concern... this is mostly a feeling, I can be

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Oleg Nesterov
On 11/25, Oleg Nesterov wrote: > > Let me first apologize, I didn't actually read this series yet. > > But I have to admit that so far I do not like this approach... > probably I am biased. Yes. And I have another concern... this is mostly a feeling, I can be easily wrong but: > On 11/25, Ian Ke

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Oleg Nesterov
Let me first apologize, I didn't actually read this series yet. But I have to admit that so far I do not like this approach... probably I am biased. On 11/25, Ian Kent wrote: > > The call_usermodehelper() function executes all binaries in the > global "init" root context. This doesn't allow a bin