Re: [RFC PATCH 12/13] mmap: Add XO support for KVM XO

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:34 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > + > > + protection_map[4] = PAGE_EXECONLY; > > + protection_map[12] = PAGE_EXECONLY; > > Can you add #defines for the bits in protection_map? Also perhaps you > can replace the p_xo/p_xr/s_x

Re: [RFC PATCH 12/13] mmap: Add XO support for KVM XO

2019-10-04 Thread Paolo Bonzini
On 03/10/19 23:23, Rick Edgecombe wrote: > + > + protection_map[4] = PAGE_EXECONLY; > + protection_map[12] = PAGE_EXECONLY; Can you add #defines for the bits in protection_map? Also perhaps you can replace the p_xo/p_xr/s_xo/s_xr checks with just with "if (pgtable_kvmxo_enabled()". Paolo