Re: [RFC PATCH 1/5] amd_iommu: Split IOMMU group initialization

2012-10-09 Thread Alex Williamson
On Tue, 2012-10-09 at 08:33 -0600, Shuah Khan wrote: > Alex, > > couple of comments in-lined: > > On Mon, Oct 8, 2012 at 10:49 PM, Alex Williamson > wrote: > > This needs to be broken apart, start with pulling all the IOMMU > > group init code into a new function. > > > > Signed-off-by: Alex Wil

Re: [RFC PATCH 1/5] amd_iommu: Split IOMMU group initialization

2012-10-09 Thread Shuah Khan
Alex, couple of comments in-lined: On Mon, Oct 8, 2012 at 10:49 PM, Alex Williamson wrote: > This needs to be broken apart, start with pulling all the IOMMU > group init code into a new function. > > Signed-off-by: Alex Williamson > --- > > drivers/iommu/amd_iommu.c | 61 > +