Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-15 Thread Petr Mladek
On Sat 2015-06-13 18:22:22, Tejun Heo wrote: > > I try to better understand why freezer is considered to be a blunt > > tool. Is it because it is a generic API, try_to_freeze() is put on > > "random" locations, so that it does not define the safe point > > precisely enough? > > Not that. I don't k

Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-13 Thread Tejun Heo
Hey, Petr. On Fri, Jun 12, 2015 at 03:24:40PM +0200, Petr Mladek wrote: > > * While hibernating, freezing writeback workers and whoever else which > > might issue IOs. This is because we have to thaw devices to issue > > IOs to write out the prepared hibernation image. If new IOs are > > i

Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-12 Thread Petr Mladek
On Wed 2015-06-10 13:31:54, Tejun Heo wrote: > Hello, Petr. > > On Tue, Jun 09, 2015 at 05:53:13PM +0200, Petr Mladek wrote: > > I think that the interaction with the hardware should be the reason to > > make them properly freezable. In the current state they are stopped at > > some random place,

Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-09 Thread Tejun Heo
Hello, Petr. On Tue, Jun 09, 2015 at 05:53:13PM +0200, Petr Mladek wrote: > I think that the interaction with the hardware should be the reason to > make them properly freezable. In the current state they are stopped at > some random place, they might either miss some event from the hardware > or

Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-09 Thread Petr Mladek
On Tue 2015-06-09 16:20:03, Tejun Heo wrote: > Hello, Petr. > > On Fri, Jun 05, 2015 at 05:01:06PM +0200, Petr Mladek wrote: > > Many kthreads already calls set_freezable() before they enter the main > > cycle. One of the reasons for creating iterant kthreads is to create > > a safe point for free

Re: [RFC PATCH 07/18] kthread: Make iterant kthreads freezable by default

2015-06-09 Thread Tejun Heo
Hello, Petr. On Fri, Jun 05, 2015 at 05:01:06PM +0200, Petr Mladek wrote: > Many kthreads already calls set_freezable() before they enter the main > cycle. One of the reasons for creating iterant kthreads is to create > a safe point for freezing and make even more kthreads properly > freezable. Th